From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH container 2/2] migrate: allow renaming of volumes
Date: Fri, 11 Feb 2022 11:29:45 +0100 [thread overview]
Message-ID: <20220211102945.3220096-3-f.gruenbichler@proxmox.com> (raw)
In-Reply-To: <20220211102945.3220096-1-f.gruenbichler@proxmox.com>
the config is now updated anyway because of target-storage support, so
volume renaming is both 'free' and improves the chances of migration
with and without changing storages actually works successfully.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
src/PVE/LXC/Migrate.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/PVE/LXC/Migrate.pm b/src/PVE/LXC/Migrate.pm
index 1739c78..64bdd38 100644
--- a/src/PVE/LXC/Migrate.pm
+++ b/src/PVE/LXC/Migrate.pm
@@ -304,6 +304,7 @@ sub phase1 {
'ratelimit_bps' => $bwlimit,
'insecure' => $opts->{migration_type} eq 'insecure',
'with_snapshots' => $volhash->{$volid}->{snapshots},
+ 'allow_rename' => 1,
};
my $logfunc = sub { $self->log('info', $_[0]); };
--
2.30.2
next prev parent reply other threads:[~2022-02-11 10:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 10:29 [pve-devel] [PATCH container 0/2] 'target-storage' follow-ups Fabian Grünbichler
2022-02-11 10:29 ` [pve-devel] [PATCH container 1/2] migrate: improve target storage checks Fabian Grünbichler
2022-02-11 10:29 ` Fabian Grünbichler [this message]
2022-02-11 11:33 ` [pve-devel] [PATCH container 0/2] 'target-storage' follow-ups Fabian Ebner
2022-02-11 15:17 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220211102945.3220096-3-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox