public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] query-url-metadata: change default user-agent to "Proxmox VE"
@ 2022-02-01 14:02 Oguz Bektas
  2022-02-02 13:17 ` Matthias Heiserer
  2022-02-04 16:50 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 2 replies; 4+ messages in thread
From: Oguz Bektas @ 2022-02-01 14:02 UTC (permalink / raw)
  To: pve-devel

to avoid being blacklisted because of the default libwww-perl user-agent

issue was reported in community forum [0]

[0]: https://forum.proxmox.com/threads/104081/

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 PVE/API2/Nodes.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/API2/Nodes.pm b/PVE/API2/Nodes.pm
index d57a1937..655493a3 100644
--- a/PVE/API2/Nodes.pm
+++ b/PVE/API2/Nodes.pm
@@ -1551,6 +1551,7 @@ __PACKAGE__->register_method({
 	my $url = $param->{url};
 
 	my $ua = LWP::UserAgent->new();
+	$ua->agent("Proxmox VE");
 
 	my $dccfg = PVE::Cluster::cfs_read_file('datacenter.cfg');
 	if ($dccfg->{http_proxy}) {
-- 
2.30.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pve-devel] [PATCH manager] query-url-metadata: change default user-agent to "Proxmox VE"
  2022-02-01 14:02 [pve-devel] [PATCH manager] query-url-metadata: change default user-agent to "Proxmox VE" Oguz Bektas
@ 2022-02-02 13:17 ` Matthias Heiserer
  2022-02-02 13:30   ` Matthias Heiserer
  2022-02-04 16:50 ` [pve-devel] applied: " Thomas Lamprecht
  1 sibling, 1 reply; 4+ messages in thread
From: Matthias Heiserer @ 2022-02-02 13:17 UTC (permalink / raw)
  To: Proxmox VE development discussion, Oguz Bektas

Tested-by: Matthias Heiserer <m.heiserer@proxmox.com>





^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [pve-devel] [PATCH manager] query-url-metadata: change default user-agent to "Proxmox VE"
  2022-02-02 13:17 ` Matthias Heiserer
@ 2022-02-02 13:30   ` Matthias Heiserer
  0 siblings, 0 replies; 4+ messages in thread
From: Matthias Heiserer @ 2022-02-02 13:30 UTC (permalink / raw)
  To: Proxmox VE development discussion, Oguz Bektas

On 02.02.2022 14:17, Matthias Heiserer wrote:
> Tested-by: Matthias Heiserer <m.heiserer@proxmox.com>

Sorry for a second mail.
I tested against the issue mentioned in the original mail. Without the 
patch I'm blocked, with the patch it works.
> 
> 
> 
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
> 
> 





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] applied: [PATCH manager] query-url-metadata: change default user-agent to "Proxmox VE"
  2022-02-01 14:02 [pve-devel] [PATCH manager] query-url-metadata: change default user-agent to "Proxmox VE" Oguz Bektas
  2022-02-02 13:17 ` Matthias Heiserer
@ 2022-02-04 16:50 ` Thomas Lamprecht
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2022-02-04 16:50 UTC (permalink / raw)
  To: Proxmox VE development discussion, Oguz Bektas

On 01.02.22 15:02, Oguz Bektas wrote:
> to avoid being blacklisted because of the default libwww-perl user-agent
> 
> issue was reported in community forum [0]
> 
> [0]: https://forum.proxmox.com/threads/104081/
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  PVE/API2/Nodes.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, with Matthias' T-b, thanks!




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2022-02-04 16:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-01 14:02 [pve-devel] [PATCH manager] query-url-metadata: change default user-agent to "Proxmox VE" Oguz Bektas
2022-02-02 13:17 ` Matthias Heiserer
2022-02-02 13:30   ` Matthias Heiserer
2022-02-04 16:50 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal