* [pve-devel] [PATCH manager] ui: fix novnc scaling radio buttons
@ 2022-01-11 10:26 Dominik Csapak
2022-01-11 15:33 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2022-01-11 10:26 UTC (permalink / raw)
To: pve-devel
when having selected 'off', the next start of the window has both
radiobuttons selected and no change is possible anymore. It seems that
the 'checked: true' triggers only after the 'init' function.
So instead remove the 'checked: true', and add the default in the init
function.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/window/Settings.js | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/www/manager6/window/Settings.js b/www/manager6/window/Settings.js
index 4aa7137c..b151adcd 100644
--- a/www/manager6/window/Settings.js
+++ b/www/manager6/window/Settings.js
@@ -34,10 +34,8 @@ Ext.define('PVE.window.Settings', {
var username = sp.get('login-username') || Proxmox.Utils.noneText;
me.lookupReference('savedUserName').setValue(Ext.String.htmlEncode(username));
- var vncMode = sp.get('novnc-scaling');
- if (vncMode !== undefined) {
- me.lookupReference('noVNCScalingGroup').setValue({ noVNCScalingField: vncMode });
- }
+ var vncMode = sp.get('novnc-scaling') || 'scale';
+ me.lookupReference('noVNCScalingGroup').setValue({ noVNCScalingField: vncMode });
let summarycolumns = sp.get('summarycolumns', 'auto');
me.lookup('summarycolumns').setValue(summarycolumns);
@@ -379,7 +377,6 @@ Ext.define('PVE.window.Settings', {
name: 'noVNCScalingField',
inputValue: 'scale',
boxLabel: 'Local Scaling',
- checked: true,
}, {
xtype: 'radiofield',
name: 'noVNCScalingField',
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] ui: fix novnc scaling radio buttons
2022-01-11 10:26 [pve-devel] [PATCH manager] ui: fix novnc scaling radio buttons Dominik Csapak
@ 2022-01-11 15:33 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-01-11 15:33 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 11.01.22 11:26, Dominik Csapak wrote:
> when having selected 'off', the next start of the window has both
> radiobuttons selected and no change is possible anymore. It seems that
> the 'checked: true' triggers only after the 'init' function.
>
> So instead remove the 'checked: true', and add the default in the init
> function.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/window/Settings.js | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-01-11 15:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-11 10:26 [pve-devel] [PATCH manager] ui: fix novnc scaling radio buttons Dominik Csapak
2022-01-11 15:33 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox