public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH login_manager, flutter_frontend 0/2] Avoid elements hiding behind Android soft nav buttons
Date: Mon, 27 Dec 2021 15:07:03 +0100	[thread overview]
Message-ID: <20211227140705.1531308-1-a.lauterer@proxmox.com> (raw)

In a few places we had the situation, that elements would get hidden
behind the Android soft nav buttons at the bottom of the screen. Placing
them inside a SafeArea element avoids this.

These instances are:
* Continue button in the Login manager when adding a new site
* Qemu HW overview list
* Qemu Power Control menu
* LXC and Qemu Options list

Unfortunately, the resulting diff is quite big since all child elements
were indented one level more.


login_manager: Aaron Lauterer (1):
  login_form: keep Continue button above Android softnav

 lib/proxmox_login_form.dart | 265 ++++++++++++++++++------------------
 1 file changed, 135 insertions(+), 130 deletions(-)


flutter_frontend: Aaron Lauterer (1):
  avoid elements hiding behind Android softnav buttons

 lib/widgets/pve_lxc_options_widget.dart       | 140 ++++----
 lib/widgets/pve_qemu_options_widget.dart      | 256 +++++++-------
 lib/widgets/pve_qemu_overview.dart            | 319 +++++++++---------
 .../pve_qemu_power_settings_widget.dart       | 178 +++++-----
 4 files changed, 451 insertions(+), 442 deletions(-)


-- 
2.30.2





             reply	other threads:[~2021-12-27 14:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-27 14:07 Aaron Lauterer [this message]
2021-12-27 14:07 ` [pve-devel] [PATCH login_manager 1/2] login_form: keep Continue button above Android softnav Aaron Lauterer
2021-12-27 14:07 ` [pve-devel] [PATCH flutter_frontend 2/2] avoid elements hiding behind Android softnav buttons Aaron Lauterer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211227140705.1531308-1-a.lauterer@proxmox.com \
    --to=a.lauterer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal