From: Stoiko Ivanov <s.ivanov@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-kernel 2/2] drop -ERESTARTSYS handling in blkdev_get_by_dev patch
Date: Thu, 23 Dec 2021 17:22:24 +0100 [thread overview]
Message-ID: <20211223162224.1120203-5-s.ivanov@proxmox.com> (raw)
In-Reply-To: <20211223162224.1120203-1-s.ivanov@proxmox.com>
ZFS 2.1.2 handles this internally
(commit 16da688f2518526389e6bff8370684a1a2a1469c)
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
---
...onfig-disable-module-BTF-debug-info.patch} | 0
...ove-the-ERESTARTSYS-handling-in-blkd.patch | 40 -------------------
2 files changed, 40 deletions(-)
rename patches/kernel/{0009-KConfig-disable-module-BTF-debug-info.patch => 0008-KConfig-disable-module-BTF-debug-info.patch} (100%)
delete mode 100644 patches/kernel/0008-Revert-block-remove-the-ERESTARTSYS-handling-in-blkd.patch
diff --git a/patches/kernel/0009-KConfig-disable-module-BTF-debug-info.patch b/patches/kernel/0008-KConfig-disable-module-BTF-debug-info.patch
similarity index 100%
rename from patches/kernel/0009-KConfig-disable-module-BTF-debug-info.patch
rename to patches/kernel/0008-KConfig-disable-module-BTF-debug-info.patch
diff --git a/patches/kernel/0008-Revert-block-remove-the-ERESTARTSYS-handling-in-blkd.patch b/patches/kernel/0008-Revert-block-remove-the-ERESTARTSYS-handling-in-blkd.patch
deleted file mode 100644
index 6c51c6e..0000000
--- a/patches/kernel/0008-Revert-block-remove-the-ERESTARTSYS-handling-in-blkd.patch
+++ /dev/null
@@ -1,40 +0,0 @@
-From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001
-From: Thomas Lamprecht <t.lamprecht@proxmox.com>
-Date: Tue, 9 Nov 2021 12:01:12 +0100
-Subject: [PATCH] Revert "block: remove the -ERESTARTSYS handling in
- blkdev_get_by_dev"
-
-This reverts commit a8ed1a0607cfa5478ff6009539f44790c4d0956d.
-
-It breaks ZFS sometimes:
-https://github.com/openzfs/zfs/issues/12301#issuecomment-873303739
-
-Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
----
- block/bdev.c | 6 ++++++
- 1 file changed, 6 insertions(+)
-
-diff --git a/block/bdev.c b/block/bdev.c
-index 485a258b0ab3..f93165f05987 100644
---- a/block/bdev.c
-+++ b/block/bdev.c
-@@ -800,6 +800,10 @@ struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder)
- if (ret)
- return ERR_PTR(ret);
-
-+ /*
-+ * If we lost a race with 'disk' being deleted, try again. See md.c.
-+ */
-+retry:
- bdev = blkdev_get_no_open(dev);
- if (!bdev)
- return ERR_PTR(-ENXIO);
-@@ -852,6 +856,8 @@ struct block_device *blkdev_get_by_dev(dev_t dev, fmode_t mode, void *holder)
- disk_unblock_events(disk);
- put_blkdev:
- blkdev_put_no_open(bdev);
-+ if (ret == -ERESTARTSYS)
-+ goto retry;
- return ERR_PTR(ret);
- }
- EXPORT_SYMBOL(blkdev_get_by_dev);
--
2.30.2
prev parent reply other threads:[~2021-12-23 16:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 16:22 [pve-devel] [PATCH zfsonlinux/kernel] update ZFS to 2.1.2 Stoiko Ivanov
2021-12-23 16:22 ` [pve-devel] [PATCH zfsonlinux 1/2] update submodule and patches to ZFS 2.1.2 Stoiko Ivanov
2021-12-23 16:22 ` [pve-devel] [PATCH zfsonlinux 2/2] d/rules: allow abigail to fail Stoiko Ivanov
2021-12-23 16:22 ` [pve-devel] [PATCH pve-kernel 1/2] patches: add Author information to disable-split-btf.patch Stoiko Ivanov
2021-12-23 16:22 ` Stoiko Ivanov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211223162224.1120203-5-s.ivanov@proxmox.com \
--to=s.ivanov@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox