From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve_flutter_frontend] workaround for novnc fullscreen behaviour
Date: Mon, 20 Dec 2021 12:37:57 +0100 [thread overview]
Message-ID: <20211220113757.3150847-1-d.csapak@proxmox.com> (raw)
since the webview seemingly does not allow javascripts 'requestFullscreen',
workaround that by making the whole webview fullscreen and hiding novncs
fullscreen button
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
| 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
--git a/lib/widgets/pve_console_menu_widget.dart b/lib/widgets/pve_console_menu_widget.dart
index 2cd2bc9..17573d6 100644
--- a/lib/widgets/pve_console_menu_widget.dart
+++ b/lib/widgets/pve_console_menu_widget.dart
@@ -180,13 +180,11 @@ class PveConsoleMenu extends StatelessWidget {
Route _createHTMLConsoleRoute() {
return PageRouteBuilder(
- pageBuilder: (context, animation, secondaryAnimation) => Card(
- child: PVEWebConsole(
- apiClient: apiClient,
- node: node,
- guestID: guestID,
- type: type,
- ),
+ pageBuilder: (context, animation, secondaryAnimation) => PVEWebConsole(
+ apiClient: apiClient,
+ node: node,
+ guestID: guestID,
+ type: type,
),
);
}
@@ -219,7 +217,7 @@ class PVEWebConsoleState extends State<PVEWebConsole> {
final ticket = widget.apiClient.credentials.ticket!;
final baseUrl = widget.apiClient.credentials.apiBaseUrl;
- var consoleUrl = "${baseUrl}/?novnc=1&node=${widget.node}&resize=scale";
+ var consoleUrl = "${baseUrl}/?novnc=1&node=${widget.node}&isFullscreen=true&resize=scale";
if (widget.guestID != null) {
final consoleType = widget.type == 'lxc' ? 'lxc' : 'kvm';
consoleUrl += "&console=${consoleType}&vmid=${widget.guestID}";
--
2.30.2
next reply other threads:[~2021-12-20 11:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-20 11:37 Dominik Csapak [this message]
2021-12-20 13:57 ` Aaron Lauterer
2021-12-20 19:55 ` Thomas Lamprecht
2021-12-21 8:06 ` Aaron Lauterer
2021-12-20 19:19 ` [pve-devel] applied: " Thomas Lamprecht
2021-12-20 19:55 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211220113757.3150847-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox