From: "Fabian Grünbichler" <f.gruenbichler@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH cluster 1/2] clusterlog: segfault reproducer
Date: Tue, 14 Dec 2021 11:19:11 +0100 [thread overview]
Message-ID: <20211214101912.3509825-1-f.gruenbichler@proxmox.com> (raw)
see next commit for details.
get_state mimics the code path triggered in the wild, the other two are
affected just the same.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
Notes:
doesn't need to be committed, just to have an easy way to check affected parts
and the fix..
data/src/Makefile | 3 ++
data/src/logtest2.c | 103 ++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 106 insertions(+)
create mode 100644 data/src/logtest2.c
diff --git a/data/src/Makefile b/data/src/Makefile
index 3d39201..1f39f67 100644
--- a/data/src/Makefile
+++ b/data/src/Makefile
@@ -35,6 +35,9 @@ create_pmxcfs_db: create_pmxcfs_db.o libpmxcfs.a
logtest: logtest.o libpmxcfs.a
$(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS)
+logtest2: logtest2.o libpmxcfs.a
+ $(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS)
+
check_memdb: check_memdb.o libpmxcfs.a
$(CC) $(CFLAGS) -o $@ $^ $(LDFLAGS) $(shell pkg-config --libs check)
diff --git a/data/src/logtest2.c b/data/src/logtest2.c
new file mode 100644
index 0000000..5f8f8f8
--- /dev/null
+++ b/data/src/logtest2.c
@@ -0,0 +1,103 @@
+/*
+ Copyright (C) 2010 - 2020 Proxmox Server Solutions GmbH
+
+ This program is free software: you can redistribute it and/or modify
+ it under the terms of the GNU Affero General Public License as published by
+ the Free Software Foundation, either version 3 of the License, or
+ (at your option) any later version.
+
+ This program is distributed in the hope that it will be useful,
+ but WITHOUT ANY WARRANTY; without even the implied warranty of
+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ GNU Affero General Public License for more details.
+
+ You should have received a copy of the GNU Affero General Public License
+ along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+ Author: Dietmar Maurer <dietmar@proxmox.com>
+
+*/
+
+#define _XOPEN_SOURCE /* glibc2 needs this */
+#include <time.h> /* for strptime */
+
+#include <stdio.h>
+#include <stdlib.h>
+#include <glib.h>
+#include <sys/types.h>
+#include <sys/syslog.h>
+#include <sys/stat.h>
+#include <fcntl.h>
+#include <errno.h>
+#include <unistd.h>
+#include <string.h>
+#include <ctype.h>
+
+#include "cfs-utils.h"
+#include "logger.h"
+
+struct clog_base {
+ uint32_t size;
+ uint32_t cpos;
+ char data[];
+};
+
+struct clusterlog {
+ GHashTable *dedup;
+ GMutex mutex;
+ clog_base_t *base;
+};
+
+cfs_t cfs = {
+ .debug = 0,
+ .nodename = "testnode",
+};
+
+void get_state(clusterlog_t *cl) {
+ unsigned int res_len;
+ clusterlog_get_state(cl, &res_len);
+}
+
+
+void insert(clusterlog_t *cl) {
+ uint32_t pid = getpid();
+ clog_entry_t *entry = (clog_entry_t *)alloca(CLOG_MAX_ENTRY_SIZE);
+ clog_pack(entry, cfs.nodename, "root", "cluster", pid, time(NULL), LOG_INFO, "short");
+ clusterlog_insert(cl, entry);
+}
+
+void insert2(clusterlog_t *cl) {
+ uint32_t pid = getpid();
+ clog_entry_t *entry = (clog_entry_t *)alloca(CLOG_MAX_ENTRY_SIZE);
+ clog_pack(entry, cfs.nodename, "root", "cluster", pid, time(NULL), LOG_INFO, "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa");
+ clusterlog_insert(cl, entry);
+}
+
+int
+main(void)
+{
+ uint32_t pid = getpid();
+
+ clusterlog_t *cl3 = clusterlog_new();
+
+ clog_entry_t *entry = (clog_entry_t *)alloca(CLOG_MAX_ENTRY_SIZE);
+ clog_pack(entry, cfs.nodename, "root", "cluster", pid, time(NULL), LOG_INFO, "starting cluster log");
+ clusterlog_insert(cl3, entry);
+
+ for (int i = 0; i < 184; i++) {
+ insert2(cl3);
+ }
+
+ for (int i = 0; i < 1629; i++) {
+ insert(cl3);
+ }
+
+ GString *outbuf = g_string_new(NULL);
+
+ // all of these segfault if they don't handle wrap-arounds pointing to already overwritten entries
+ clusterlog_dump(cl3, outbuf, NULL, 8192);
+ clog_dump(cl3->base);
+ get_state(cl3);
+
+ clusterlog_destroy(cl3);
+}
--
2.30.2
next reply other threads:[~2021-12-14 10:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-14 10:19 Fabian Grünbichler [this message]
2021-12-14 10:19 ` [pve-devel] [PATCH cluster 2/2] clusterlog: fix segfault / wrong iteration bounds Fabian Grünbichler
2021-12-15 14:56 ` [pve-devel] applied: " Thomas Lamprecht
2021-12-15 14:55 ` [pve-devel] applied: [PATCH cluster 1/2] clusterlog: segfault reproducer Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211214101912.3509825-1-f.gruenbichler@proxmox.com \
--to=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox