[pve-devel] [PATCH widget-toolkit 1/1] window: safe destroy: make note more visible

[pve-devel] [PATCH widget-toolkit 1/1] window: safe destroy: make note more visible

[Fabian Ebner]

by not using a smaller font size and using the pmx-hint class. Also
don't align to the middle, as everything else is left-aligned.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---

AFAICT, the only current user is datastore deletion in PBS and IMHO
it doesn't look worse after these changes.

 src/window/SafeDestroy.js | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js
index ead0e04..474c21e 100644
--- a/src/window/SafeDestroy.js
+++ b/src/window/SafeDestroy.js
@@ -159,15 +159,12 @@ Ext.define('Proxmox.window.SafeDestroy', {
 			hidden: true,
 			layout: {
 			    type: 'vbox',
-			    align: 'middle',
 			},
-			height: 25,
 			items: [
 			    {
 				xtype: 'component',
 				reference: 'noteCmp',
-				width: '300px',
-				style: 'font-size: smaller; overflow: hidden; white-space: nowrap; text-overflow: ellipsis;',
+				userCls: 'pmx-hint',
 			    },
 			],
 		    },
-- 
2.30.2

[pve-devel] [PATCH manager 1/1] window: safe destroy guest: add note that referenced disks are destroyed

[Fabian Ebner]

It's not clear to all users otherwise[0].

[0]: https://forum.proxmox.com/threads/100996/post-436919

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 www/manager6/window/SafeDestroyGuest.js | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/www/manager6/window/SafeDestroyGuest.js b/www/manager6/window/SafeDestroyGuest.js
index 9a7a0e21..3328293a 100644
--- a/www/manager6/window/SafeDestroyGuest.js
+++ b/www/manager6/window/SafeDestroyGuest.js
@@ -30,6 +30,8 @@ Ext.define('PVE.window.SafeDestroyGuest', {
 	},
     ],
 
+    note: gettext('Referenced disks will always be destroyed.'),
+
     getParams: function() {
 	let me = this;
 
-- 
2.30.2

[pve-devel] applied: [PATCH manager 1/1] window: safe destroy guest: add note that referenced disks are destroyed

[Thomas Lamprecht]

On 13.12.21 09:25, Fabian Ebner wrote:
> It's not clear to all users otherwise[0].
> 
> [0]: https://forum.proxmox.com/threads/100996/post-436919
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  www/manager6/window/SafeDestroyGuest.js | 2 ++
>  1 file changed, 2 insertions(+)
> 
>

applied, thanks!

[pve-devel] applied: [PATCH widget-toolkit 1/1] window: safe destroy: make note more visible

[Thomas Lamprecht]

On 13.12.21 09:25, Fabian Ebner wrote:
> by not using a smaller font size and using the pmx-hint class. Also
> don't align to the middle, as everything else is left-aligned.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> AFAICT, the only current user is datastore deletion in PBS and IMHO
> it doesn't look worse after these changes.
> 
>  src/window/SafeDestroy.js | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
>

applied, thanks!