public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit 1/1] window: safe destroy: make note more visible
Date: Mon, 13 Dec 2021 09:25:13 +0100	[thread overview]
Message-ID: <20211213082514.12729-1-f.ebner@proxmox.com> (raw)

by not using a smaller font size and using the pmx-hint class. Also
don't align to the middle, as everything else is left-aligned.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---

AFAICT, the only current user is datastore deletion in PBS and IMHO
it doesn't look worse after these changes.

 src/window/SafeDestroy.js | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js
index ead0e04..474c21e 100644
--- a/src/window/SafeDestroy.js
+++ b/src/window/SafeDestroy.js
@@ -159,15 +159,12 @@ Ext.define('Proxmox.window.SafeDestroy', {
 			hidden: true,
 			layout: {
 			    type: 'vbox',
-			    align: 'middle',
 			},
-			height: 25,
 			items: [
 			    {
 				xtype: 'component',
 				reference: 'noteCmp',
-				width: '300px',
-				style: 'font-size: smaller; overflow: hidden; white-space: nowrap; text-overflow: ellipsis;',
+				userCls: 'pmx-hint',
 			    },
 			],
 		    },
-- 
2.30.2





             reply	other threads:[~2021-12-13  8:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-13  8:25 Fabian Ebner [this message]
2021-12-13  8:25 ` [pve-devel] [PATCH manager 1/1] window: safe destroy guest: add note that referenced disks are destroyed Fabian Ebner
2022-01-13 16:16   ` [pve-devel] applied: " Thomas Lamprecht
2022-01-13 12:42 ` [pve-devel] applied: [PATCH widget-toolkit 1/1] window: safe destroy: make note more visible Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211213082514.12729-1-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal