* [pve-devel] [PATCH qemu-server v2] apply pending changes at vm stop only if the section is not empty
@ 2021-12-02 11:43 Oguz Bektas
2021-12-02 18:28 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Oguz Bektas @ 2021-12-02 11:43 UTC (permalink / raw)
To: pve-devel
we also have the same skipping logic when starting vms, this way we
avoid calling 'write_config' when there are no present changes to
commit.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
v1->v2:
* keep using the hardcoded 1 for vm_stop_cleanup call since we do an early return anyway
PVE/QemuServer.pm | 2 ++
1 file changed, 2 insertions(+)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 45b704d..0071a06 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -4998,6 +4998,8 @@ sub vmconfig_delete_or_detach_drive {
sub vmconfig_apply_pending {
my ($vmid, $conf, $storecfg, $errors) = @_;
+ return if !scalar(keys %{$conf->{pending}});
+
my $add_apply_error = sub {
my ($opt, $msg) = @_;
my $err_msg = "unable to apply pending change $opt : $msg";
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH qemu-server v2] apply pending changes at vm stop only if the section is not empty
2021-12-02 11:43 [pve-devel] [PATCH qemu-server v2] apply pending changes at vm stop only if the section is not empty Oguz Bektas
@ 2021-12-02 18:28 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-12-02 18:28 UTC (permalink / raw)
To: Proxmox VE development discussion, Oguz Bektas
On 02.12.21 12:43, Oguz Bektas wrote:
> we also have the same skipping logic when starting vms, this way we
> avoid calling 'write_config' when there are no present changes to
> commit.
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
> v1->v2:
> * keep using the hardcoded 1 for vm_stop_cleanup call since we do an early return anyway
>
>
> PVE/QemuServer.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, albeit I modified/added a bit to the commit message to clarify why
this is nicer to do (or in this case rather not to do). thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-12-02 18:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-02 11:43 [pve-devel] [PATCH qemu-server v2] apply pending changes at vm stop only if the section is not empty Oguz Bektas
2021-12-02 18:28 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox