From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] fix #3689: add gridhandle to firewall rules to indicate drag/drop
Date: Thu, 2 Dec 2021 11:38:47 +0100 [thread overview]
Message-ID: <20211202103847.2519952-1-d.csapak@proxmox.com> (raw)
dragHandle was copied from the BootOrderEdit.
Also increases the width by 23px to make space for it.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/grid/FirewallRules.js | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/www/manager6/grid/FirewallRules.js b/www/manager6/grid/FirewallRules.js
index f3e02f6a..1fe13ea6 100644
--- a/www/manager6/grid/FirewallRules.js
+++ b/www/manager6/grid/FirewallRules.js
@@ -623,19 +623,19 @@ Ext.define('PVE.FirewallRules', {
// similar to xtype: 'rownumberer',
dataIndex: 'pos',
resizable: false,
- minWidth: 42,
- maxWidth: 60,
+ minWidth: 65,
+ maxWidth: 83,
flex: 1,
sortable: false,
- align: 'right',
hideable: false,
menuDisabled: true,
renderer: function(value, metaData, record, rowIdx, colIdx) {
metaData.tdCls = Ext.baseCSSPrefix + 'grid-cell-special';
+ let dragHandle = "<i class='pve-grid-fa fa fa-fw fa-reorder cursor-move'></i>";
if (value >= 0) {
- return value;
+ return dragHandle + value;
}
- return '';
+ return dragHandle;
},
},
{
--
2.30.2
next reply other threads:[~2021-12-02 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 10:38 Dominik Csapak [this message]
2021-12-02 18:19 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211202103847.2519952-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox