public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH v2 manager container 0/2] lazytime mount option
@ 2021-12-01 15:17 Oguz Bektas
  2021-12-01 15:17 ` [pve-devel] [PATCH v2 container 1/2] config: allow 'lazytime' mount option for containers Oguz Bektas
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Oguz Bektas @ 2021-12-01 15:17 UTC (permalink / raw)
  To: pve-devel


 pve-container:

 Oguz Bektas (1):
  config: allow 'lazytime' mount option for containers

 src/PVE/LXC/Config.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

 pve-manager:

 Oguz Bektas (1):
  lxc: add lazytime mount option

 www/manager6/lxc/MPEdit.js | 1 +
 1 file changed, 1 insertion(+)

-- 
2.30.2




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH v2 container 1/2] config: allow 'lazytime' mount option for containers
  2021-12-01 15:17 [pve-devel] [PATCH v2 manager container 0/2] lazytime mount option Oguz Bektas
@ 2021-12-01 15:17 ` Oguz Bektas
  2021-12-01 15:17 ` [pve-devel] [PATCH v2 manager 2/2] lxc: add lazytime mount option Oguz Bektas
  2021-12-01 15:32 ` [pve-devel] applied-series: [PATCH v2 manager container 0/2] " Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Oguz Bektas @ 2021-12-01 15:17 UTC (permalink / raw)
  To: pve-devel

worked fine here in ubuntu container.

root@CT1022:/# mount | grep lazy
/var/lib/pve/local-btrfs/images/1022/vm-1022-disk-0/disk.raw on /     type ext4 (rw,relatime,lazytime)
/var/lib/pve/local-btrfs/images/1022/vm-1022-disk-0/disk.raw on /snap type ext4 (rw,relatime,lazytime)

requested in community forum [0]

[0]: https://forum.proxmox.com/threads/100454/

Tested-by: Dylan Whyte <d.whyte@proxmox.com>
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---

v1->v2:
* no changes, added dylan's test tag


 src/PVE/LXC/Config.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/LXC/Config.pm b/src/PVE/LXC/Config.pm
index 1e28a88..6c2acd6 100644
--- a/src/PVE/LXC/Config.pm
+++ b/src/PVE/LXC/Config.pm
@@ -281,7 +281,7 @@ sub __snapshot_rollback_get_unused {
 cfs_register_file('/lxc/', \&parse_pct_config, \&write_pct_config);
 
 
-my $valid_mount_option_re = qr/(noatime|nodev|nosuid|noexec)/;
+my $valid_mount_option_re = qr/(noatime|lazytime|nodev|nosuid|noexec)/;
 
 sub is_valid_mount_option {
     my ($option) = @_;
-- 
2.30.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] [PATCH v2 manager 2/2] lxc: add lazytime mount option
  2021-12-01 15:17 [pve-devel] [PATCH v2 manager container 0/2] lazytime mount option Oguz Bektas
  2021-12-01 15:17 ` [pve-devel] [PATCH v2 container 1/2] config: allow 'lazytime' mount option for containers Oguz Bektas
@ 2021-12-01 15:17 ` Oguz Bektas
  2021-12-01 15:32 ` [pve-devel] applied-series: [PATCH v2 manager container 0/2] " Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Oguz Bektas @ 2021-12-01 15:17 UTC (permalink / raw)
  To: pve-devel

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
v2:
* added patch, thanks to dylan for pointing this out!

 www/manager6/lxc/MPEdit.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/lxc/MPEdit.js b/www/manager6/lxc/MPEdit.js
index dba69cb4..b8c6b6cb 100644
--- a/www/manager6/lxc/MPEdit.js
+++ b/www/manager6/lxc/MPEdit.js
@@ -300,6 +300,7 @@ Ext.define('PVE.lxc.MountPointInputPanel', {
 	    fieldLabel: gettext('Mount options'),
 	    deleteEmpty: false,
 	    comboItems: [
+		['lazytime', 'lazytime'],
 		['noatime', 'noatime'],
 		['nodev', 'nodev'],
 		['noexec', 'noexec'],
-- 
2.30.2





^ permalink raw reply	[flat|nested] 4+ messages in thread

* [pve-devel] applied-series: [PATCH v2 manager container 0/2] lazytime mount option
  2021-12-01 15:17 [pve-devel] [PATCH v2 manager container 0/2] lazytime mount option Oguz Bektas
  2021-12-01 15:17 ` [pve-devel] [PATCH v2 container 1/2] config: allow 'lazytime' mount option for containers Oguz Bektas
  2021-12-01 15:17 ` [pve-devel] [PATCH v2 manager 2/2] lxc: add lazytime mount option Oguz Bektas
@ 2021-12-01 15:32 ` Thomas Lamprecht
  2 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2021-12-01 15:32 UTC (permalink / raw)
  To: Proxmox VE development discussion, Oguz Bektas

On 01.12.21 16:17, Oguz Bektas wrote:
> 
>  pve-container:
> 
>  Oguz Bektas (1):
>   config: allow 'lazytime' mount option for containers
> 
>  src/PVE/LXC/Config.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>  pve-manager:
> 
>  Oguz Bektas (1):
>   lxc: add lazytime mount option
> 
>  www/manager6/lxc/MPEdit.js | 1 +
>  1 file changed, 1 insertion(+)
> 


applied, thanks!




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-12-01 15:32 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-12-01 15:17 [pve-devel] [PATCH v2 manager container 0/2] lazytime mount option Oguz Bektas
2021-12-01 15:17 ` [pve-devel] [PATCH v2 container 1/2] config: allow 'lazytime' mount option for containers Oguz Bektas
2021-12-01 15:17 ` [pve-devel] [PATCH v2 manager 2/2] lxc: add lazytime mount option Oguz Bektas
2021-12-01 15:32 ` [pve-devel] applied-series: [PATCH v2 manager container 0/2] " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal