* [pve-devel] [PATCH widget-toolkit] ui: journalview: fix wrong first load with timespan
@ 2021-11-23 9:49 Dominik Csapak
2021-11-24 10:44 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-11-23 9:49 UTC (permalink / raw)
To: pve-devel
calling updateParams here lead to making an api call with the default
timespan (last 3 days) on pbs/pmg when going to the 'administration'
panel, even though it would never be shown since on tab activate we would
show the 'live mode' which does not use the timespan
on pve this did not happen since the journalview is on its own page and
the change to livemode triggered too fast..
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/panel/JournalView.js | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/panel/JournalView.js b/src/panel/JournalView.js
index f672be1..c74345f 100644
--- a/src/panel/JournalView.js
+++ b/src/panel/JournalView.js
@@ -198,7 +198,6 @@ Ext.define('Proxmox.panel.JournalView', {
view.loadTask = new Ext.util.DelayedTask(me.doLoad, me, [true, false]);
- me.updateParams();
view.task = Ext.TaskManager.start({
run: function() {
if (!view.isVisible() || !view.scrollToEnd || !viewmodel.get('livemode')) {
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* [pve-devel] applied: [PATCH widget-toolkit] ui: journalview: fix wrong first load with timespan
2021-11-23 9:49 [pve-devel] [PATCH widget-toolkit] ui: journalview: fix wrong first load with timespan Dominik Csapak
@ 2021-11-24 10:44 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-11-24 10:44 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 23.11.21 10:49, Dominik Csapak wrote:
> calling updateParams here lead to making an api call with the default
> timespan (last 3 days) on pbs/pmg when going to the 'administration'
> panel, even though it would never be shown since on tab activate we would
> show the 'live mode' which does not use the timespan
>
> on pve this did not happen since the journalview is on its own page and
> the change to livemode triggered too fast..
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/panel/JournalView.js | 1 -
> 1 file changed, 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-24 10:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-23 9:49 [pve-devel] [PATCH widget-toolkit] ui: journalview: fix wrong first load with timespan Dominik Csapak
2021-11-24 10:44 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox