From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit] data: diffstore: fix autoDestroyRstore option
Date: Thu, 18 Nov 2021 10:50:10 +0100 [thread overview]
Message-ID: <20211118095010.2387263-1-d.csapak@proxmox.com> (raw)
the change from extjs 6.0.1 to 7.0.0 removed 'onDestroy' but brought
us 'doDestroy' for stores
we did not notice since 'onDestroy' was a private method and thus
the changelog did not mention this (doDestroy is a public method meant
exactly for our use case)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/data/DiffStore.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/data/DiffStore.js b/src/data/DiffStore.js
index e4143f5..935bc11 100644
--- a/src/data/DiffStore.js
+++ b/src/data/DiffStore.js
@@ -28,7 +28,7 @@ Ext.define('Proxmox.data.DiffStore', {
// config is passed instead of an existing rstore instance
autoDestroyRstore: false,
- onDestroy: function() {
+ doDestroy: function() {
let me = this;
if (me.autoDestroyRstore) {
if (Ext.isFunction(me.rstore.destroy)) {
--
2.30.2
next reply other threads:[~2021-11-18 9:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-18 9:50 Dominik Csapak [this message]
2021-11-18 10:17 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211118095010.2387263-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox