public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager] api: backup: normalize 'dow' format when converting
@ 2021-11-17 14:21 Dominik Csapak
  0 siblings, 0 replies; only message in thread
From: Dominik Csapak @ 2021-11-17 14:21 UTC (permalink / raw)
  To: pve-devel

the old web ui sends the days as seperate parameters, which will
be concatenated by a null-byte in the api, causing it to land it this
way in the jobs.cfg

to fix this, split+join the list to get a well-formed dow list

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 PVE/API2/Backup.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/API2/Backup.pm b/PVE/API2/Backup.pm
index 3b1d5299..c4970bc3 100644
--- a/PVE/API2/Backup.pm
+++ b/PVE/API2/Backup.pm
@@ -52,6 +52,7 @@ my $convert_to_schedule = sub {
 
     my $starttime = $job->{starttime};
     my $dow = $job->{dow};
+    $dow = join(',', PVE::Tools::split_list($dow)) if defined($dow);
 
     if (!$dow || $dow eq ALL_DAYS) {
 	return "$starttime";
-- 
2.30.2





^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-11-17 14:21 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-17 14:21 [pve-devel] [PATCH manager] api: backup: normalize 'dow' format when converting Dominik Csapak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal