* [pve-devel] [PATCH manager] api: metrics: use complete config for testing the connection
@ 2021-11-15 13:57 Dominik Csapak
2021-11-15 15:19 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-11-15 13:57 UTC (permalink / raw)
To: pve-devel
not only the given parameters, e.g. at the moment, the gui will
never send a 'verify-certificate' parameter, even if set in the config
by using the complete resulting config, we test the actual settings.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
PVE/API2/Cluster/MetricServer.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/API2/Cluster/MetricServer.pm b/PVE/API2/Cluster/MetricServer.pm
index a6b99d4f..882cda10 100644
--- a/PVE/API2/Cluster/MetricServer.pm
+++ b/PVE/API2/Cluster/MetricServer.pm
@@ -238,7 +238,7 @@ __PACKAGE__->register_method ({
$plugin->on_update_hook($id, $data, $sensitive_params);
- $plugin->test_connection($opts, $id);
+ $plugin->test_connection($data, $id);
PVE::Cluster::cfs_write_file('status.cfg', $cfg);
});
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] api: metrics: use complete config for testing the connection
2021-11-15 13:57 [pve-devel] [PATCH manager] api: metrics: use complete config for testing the connection Dominik Csapak
@ 2021-11-15 15:19 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-11-15 15:19 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 15.11.21 14:57, Dominik Csapak wrote:
> not only the given parameters, e.g. at the moment, the gui will
> never send a 'verify-certificate' parameter, even if set in the config
>
> by using the complete resulting config, we test the actual settings.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> PVE/API2/Cluster/MetricServer.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-11-15 15:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-15 13:57 [pve-devel] [PATCH manager] api: metrics: use complete config for testing the connection Dominik Csapak
2021-11-15 15:19 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox