From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH storage 1/2] activate storage: improve error when check_connection dies
Date: Mon, 15 Nov 2021 13:37:55 +0100 [thread overview]
Message-ID: <20211115123756.146659-1-f.ebner@proxmox.com> (raw)
by making sure the storage ID is part of the error. This can happen
for (at least) CIFS, and GlusterFS with local server.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
PVE/Storage.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/Storage.pm b/PVE/Storage.pm
index d64019f..40972c9 100755
--- a/PVE/Storage.pm
+++ b/PVE/Storage.pm
@@ -1056,7 +1056,8 @@ sub activate_storage {
activate_storage($cfg, $baseid, $cache);
}
- if (!$plugin->check_connection($storeid, $scfg)) {
+ if (! eval { $plugin->check_connection($storeid, $scfg) }) {
+ die "connection check for storage '$storeid' failed - $@\n" if $@;
die "storage '$storeid' is not online\n";
}
--
2.30.2
next reply other threads:[~2021-11-15 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-15 12:37 Fabian Ebner [this message]
2021-11-15 12:37 ` [pve-devel] [PATCH storage 2/2] cifs: check connection: bubble up NT_STATUS_LOGON_FAILURE Fabian Ebner
2022-03-16 16:37 ` [pve-devel] applied: " Thomas Lamprecht
2022-03-16 16:37 ` [pve-devel] applied: [PATCH storage 1/2] activate storage: improve error when check_connection dies Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211115123756.146659-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox