public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit] window/TfaWindow: fix text format
Date: Fri, 12 Nov 2021 15:40:04 +0100	[thread overview]
Message-ID: <20211112144004.2506264-1-d.csapak@proxmox.com> (raw)

Ext.String.format was missing to show the number correctly

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
alternatively, we could simply change the gettext, but
this way we are more flexible if we want to change the number in the
future
 src/window/TfaWindow.js | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/window/TfaWindow.js b/src/window/TfaWindow.js
index d568f9b..27d53f0 100644
--- a/src/window/TfaWindow.js
+++ b/src/window/TfaWindow.js
@@ -384,7 +384,10 @@ Ext.define('Proxmox.window.TfaLoginWindow', {
 			reference: 'recoveryLow',
 			hidden: true,
 			html: '<i class="fa fa-exclamation-triangle warning"></i>'
-			    + gettext('Less than {0} recovery keys available. Please generate a new set after login!'),
+			    + Ext.String.format(
+				gettext('Less than {0} recovery keys available. Please generate a new set after login!'),
+				4,
+			    ),
 		    },
 		],
 	    },
-- 
2.30.2





             reply	other threads:[~2021-11-12 14:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-12 14:40 Dominik Csapak [this message]
2021-11-12 15:14 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211112144004.2506264-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal