From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 4/4] ui: dc/Backup: add comment field and column
Date: Wed, 10 Nov 2021 15:02:56 +0100 [thread overview]
Message-ID: <20211110140256.1863209-5-d.csapak@proxmox.com> (raw)
In-Reply-To: <20211110140256.1863209-1-d.csapak@proxmox.com>
and hide the ID column by default
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/dc/Backup.js | 17 ++++++++++++++++-
www/manager6/dc/BackupJobDetail.js | 5 +++++
2 files changed, 21 insertions(+), 1 deletion(-)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 24fa94a6..45ee7022 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -238,6 +238,14 @@ Ext.define('PVE.dc.BackupEdit', {
onlineHelp: 'chapter_vzdump',
column1: column1,
column2: column2,
+ columnB: [
+ {
+ xtype: 'proxmoxtextfield',
+ name: 'comment',
+ fieldLabel: gettext('Comment'),
+ deleteEmpty: !me.isCreate,
+ },
+ ],
onGetValues: function(values) {
if (!values.node) {
if (!me.isCreate) {
@@ -717,6 +725,7 @@ Ext.define('PVE.dc.BackupView', {
{
header: gettext('ID'),
dataIndex: 'id',
+ hidden: true,
},
{
header: gettext('Node'),
@@ -742,8 +751,14 @@ Ext.define('PVE.dc.BackupView', {
dataIndex: 'storage',
},
{
- header: gettext('Selection'),
+ header: gettext('Comment'),
+ dataIndex: 'comment',
+ renderer: Ext.htmlEncode,
flex: 1,
+ },
+ {
+ header: gettext('Selection'),
+ flex: 2,
sortable: false,
dataIndex: 'vmid',
renderer: PVE.Utils.render_backup_selection,
diff --git a/www/manager6/dc/BackupJobDetail.js b/www/manager6/dc/BackupJobDetail.js
index 19b3b1a3..8300a7d2 100644
--- a/www/manager6/dc/BackupJobDetail.js
+++ b/www/manager6/dc/BackupJobDetail.js
@@ -246,6 +246,11 @@ Ext.define('PVE.dc.BackupInfo', {
],
columnB: [
+ {
+ xtype: 'displayfield',
+ name: 'comment',
+ fieldLabel: gettext('Comment'),
+ },
{
xtype: 'label',
name: 'pruneLabel',
--
2.30.2
next prev parent reply other threads:[~2021-11-10 14:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-10 14:02 [pve-devel] [PATCH manager 0/4] followups for vzdump scheduling2 Dominik Csapak
2021-11-10 14:02 ` [pve-devel] [PATCH manager 1/4] Jobs/VZDump: encode/decode 'prune-backups' where needed Dominik Csapak
2021-11-10 14:02 ` [pve-devel] [PATCH manager 2/4] ui: dc/BackupEdit: use correct validation Dominik Csapak
2021-11-10 14:02 ` [pve-devel] [PATCH manager 3/4] api: backup/jobs: add comment field to jobs Dominik Csapak
2021-11-10 14:02 ` Dominik Csapak [this message]
2021-11-10 17:18 ` [pve-devel] [PATCH manager 0/4] followups for vzdump scheduling2 Thomas Lamprecht
2021-11-10 20:37 ` [pve-devel] applied-series: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211110140256.1863209-5-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox