public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH qemu-server] vzdump: increase timeout for QMP 'cont' after backup start
@ 2021-10-27 11:34 Stefan Reiter
  2021-10-27 11:52 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Reiter @ 2021-10-27 11:34 UTC (permalink / raw)
  To: pve-devel

Since 'backup' can now work asynchronously, QEMU may not be ready to
receive the next QMP command ('cont') immediately. Thus, increase the
timeout, to avoid aborted backups in slow environments.

There may be a deeper QEMU bug hidden under the covers here too, but at
least one user reported success with simply increasing the timeout:
https://forum.proxmox.com/threads/pve7-pbs2-backup-timeout-qmp-command-cont-failed-got-timeout.95212/page-2#post-426261

See also:
https://bugzilla.proxmox.com/show_bug.cgi?id=3693
https://forum.proxmox.com/threads/problem-seit-update-auf-7-0.97388/
https://forum.proxmox.com/threads/error-with-backup-when-backing-up-qmp-command-query-backup-failed-got-wrong-command-id.88017/page-3#post-416339

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
 PVE/VZDump/QemuServer.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/VZDump/QemuServer.pm b/PVE/VZDump/QemuServer.pm
index b133694..17cf724 100644
--- a/PVE/VZDump/QemuServer.pm
+++ b/PVE/VZDump/QemuServer.pm
@@ -867,7 +867,7 @@ sub resume_vm_after_job_start {
     } else {
 	$self->loginfo("resuming VM again");
     }
-    mon_cmd($vmid, 'cont');
+    mon_cmd($vmid, 'cont', timeout => 45);
 }
 
 # stop again if VM was not running before
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: Re: [PATCH qemu-server] vzdump: increase timeout for QMP 'cont' after backup start
  2021-10-27 11:34 [pve-devel] [PATCH qemu-server] vzdump: increase timeout for QMP 'cont' after backup start Stefan Reiter
@ 2021-10-27 11:52 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-10-27 11:52 UTC (permalink / raw)
  To: Proxmox VE development discussion, Stefan Reiter

On 27/10/2021 13:34, Stefan Reiter wrote:
> Since 'backup' can now work asynchronously, QEMU may not be ready to
> receive the next QMP command ('cont') immediately. Thus, increase the
> timeout, to avoid aborted backups in slow environments.
> 
> There may be a deeper QEMU bug hidden under the covers here too, but at
> least one user reported success with simply increasing the timeout:
> https://forum.proxmox.com/threads/pve7-pbs2-backup-timeout-qmp-command-cont-failed-got-timeout.95212/page-2#post-426261
> 
> See also:
> https://bugzilla.proxmox.com/show_bug.cgi?id=3693
> https://forum.proxmox.com/threads/problem-seit-update-auf-7-0.97388/
> https://forum.proxmox.com/threads/error-with-backup-when-backing-up-qmp-command-query-backup-failed-got-wrong-command-id.88017/page-3#post-416339
> 
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>  PVE/VZDump/QemuServer.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-10-27 11:52 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-27 11:34 [pve-devel] [PATCH qemu-server] vzdump: increase timeout for QMP 'cont' after backup start Stefan Reiter
2021-10-27 11:52 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal