* [pve-devel] [PATCH common] cgroupv: fix parsing disk writes for cgroup v2
@ 2021-10-25 14:24 Dominik Csapak
2021-10-27 10:04 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2021-10-25 14:24 UTC (permalink / raw)
To: pve-devel
'wbytes' is for writes, but we accidentally added the value to 'diskread'
which left 'diskwrite' always zero
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/PVE/CGroup.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/PVE/CGroup.pm b/src/PVE/CGroup.pm
index dd9b034..44b3297 100644
--- a/src/PVE/CGroup.pm
+++ b/src/PVE/CGroup.pm
@@ -263,7 +263,7 @@ sub get_io_stats {
$res->{diskread} += $b;
}
if (my $b = $dev->{wbytes}) {
- $res->{diskread} += $b;
+ $res->{diskwrite} += $b;
}
}
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: Re: [PATCH common] cgroupv: fix parsing disk writes for cgroup v2
2021-10-25 14:24 [pve-devel] [PATCH common] cgroupv: fix parsing disk writes for cgroup v2 Dominik Csapak
@ 2021-10-27 10:04 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-10-27 10:04 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
On 25/10/2021 16:24, Dominik Csapak wrote:
> 'wbytes' is for writes, but we accidentally added the value to 'diskread'
> which left 'diskwrite' always zero
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/PVE/CGroup.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
changed the commit subject to "cgroup v2: io stats: fix parsing disk writes" though
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-10-27 10:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-25 14:24 [pve-devel] [PATCH common] cgroupv: fix parsing disk writes for cgroup v2 Dominik Csapak
2021-10-27 10:04 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox