public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH common] cgroupv: fix parsing disk writes for cgroup v2
Date: Mon, 25 Oct 2021 16:24:25 +0200	[thread overview]
Message-ID: <20211025142425.2322526-1-d.csapak@proxmox.com> (raw)

'wbytes' is for writes, but we accidentally added the value to 'diskread'
which left 'diskwrite' always zero

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/PVE/CGroup.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/PVE/CGroup.pm b/src/PVE/CGroup.pm
index dd9b034..44b3297 100644
--- a/src/PVE/CGroup.pm
+++ b/src/PVE/CGroup.pm
@@ -263,7 +263,7 @@ sub get_io_stats {
 		$res->{diskread} += $b;
 	    }
 	    if (my $b = $dev->{wbytes}) {
-		$res->{diskread} += $b;
+		$res->{diskwrite} += $b;
 	    }
 	}
 
-- 
2.30.2





             reply	other threads:[~2021-10-25 14:24 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-25 14:24 Dominik Csapak [this message]
2021-10-27 10:04 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211025142425.2322526-1-d.csapak@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal