public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Oguz Bektas <o.bektas@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH common] cgroup: fix default values for change_cpu_quota (cgroup v1)
Date: Thu, 21 Oct 2021 16:36:19 +0200	[thread overview]
Message-ID: <20211021143619.1591105-1-o.bektas@proxmox.com> (raw)

when period is undefined it should be set to 100ms (default value)

=====
cpu.cfs_quota_us: the total available run-time within a period (in
microseconds)
cpu.cfs_period_us: the length of a period (in microseconds)
cpu.stat: exports throttling statistics [explained further below]

The default values are:
    cpu.cfs_period_us=100ms
    cpu.cfs_quota=-1
=====
see [0]

[0]: https://www.kernel.org/doc/Documentation/scheduler/sched-bwc.txt

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 src/PVE/CGroup.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/PVE/CGroup.pm b/src/PVE/CGroup.pm
index 21681b8..17d2a75 100644
--- a/src/PVE/CGroup.pm
+++ b/src/PVE/CGroup.pm
@@ -467,8 +467,8 @@ sub change_cpu_quota {
 	    PVE::ProcFSTools::write_proc_entry("$path/cpu.max", 'max');
 	}
     } elsif ($ver == 1) {
-	$quota //= -1; # unlimited
-	$period //= -1;
+	$quota //= -1; # default unlimited
+	$period //= 100000; # default 100ms = 100000us
 	PVE::ProcFSTools::write_proc_entry("$path/cpu.cfs_period_us", $period);
 	PVE::ProcFSTools::write_proc_entry("$path/cpu.cfs_quota_us", $quota);
     } else {
-- 
2.30.2





             reply	other threads:[~2021-10-21 14:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-21 14:36 Oguz Bektas [this message]
2021-10-22  9:42 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211021143619.1591105-1-o.bektas@proxmox.com \
    --to=o.bektas@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal