From: Aaron Lauterer <a.lauterer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 qemu-server 6/9] api: move-disk: cleanup very long lines
Date: Thu, 21 Oct 2021 13:30:27 +0200 [thread overview]
Message-ID: <20211021113030.2649985-7-a.lauterer@proxmox.com> (raw)
In-Reply-To: <20211021113030.2649985-1-a.lauterer@proxmox.com>
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
PVE/API2/Qemu.pm | 25 ++++++++++++++++++++-----
1 file changed, 20 insertions(+), 5 deletions(-)
diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index d2d9b1d..f652b12 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -3318,13 +3318,15 @@ __PACKAGE__->register_method({
},
delete => {
type => 'boolean',
- description => "Delete the original disk after successful copy. By default the original disk is kept as unused disk.",
+ description => "Delete the original disk after successful copy. By default the " .
+ "original disk is kept as unused disk.",
optional => 1,
default => 0,
},
digest => {
type => 'string',
- description => 'Prevent changes if current configuration file has different SHA1 digest. This can be used to prevent concurrent modifications.',
+ description => 'Prevent changes if current configuration file has different SHA1 " .
+ "digest. This can be used to prevent concurrent modifications.',
maxLength => 40,
optional => 1,
},
@@ -3403,11 +3405,20 @@ __PACKAGE__->register_method({
(!$format || !$oldfmt || $oldfmt eq $format);
# this only checks snapshots because $disk is passed!
- my $snapshotted = PVE::QemuServer::Drive::is_volume_in_use($storecfg, $conf, $disk, $old_volid);
+ my $snapshotted = PVE::QemuServer::Drive::is_volume_in_use(
+ $storecfg,
+ $conf,
+ $disk,
+ $old_volid
+ );
die "you can't move a disk with snapshots and delete the source\n"
if $snapshotted && $param->{delete};
- PVE::Cluster::log_msg('info', $authuser, "move disk VM $vmid: move --disk $disk --storage $storeid");
+ PVE::Cluster::log_msg(
+ 'info',
+ $authuser,
+ "move disk VM $vmid: move --disk $disk --storage $storeid"
+ );
my $running = PVE::QemuServer::check_running($vmid);
@@ -3426,7 +3437,11 @@ __PACKAGE__->register_method({
if $snapshotted;
my $bwlimit = extract_param($param, 'bwlimit');
- my $movelimit = PVE::Storage::get_bandwidth_limit('move', [$oldstoreid, $storeid], $bwlimit);
+ my $movelimit = PVE::Storage::get_bandwidth_limit(
+ 'move',
+ [$oldstoreid, $storeid],
+ $bwlimit
+ );
my $newdrive = PVE::QemuServer::clone_disk(
$storecfg,
--
2.30.2
next prev parent reply other threads:[~2021-10-21 11:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 11:30 [pve-devel] [PATCH v3 storage qemu-server container 0/9] move disk or volume to other guests Aaron Lauterer
2021-10-21 11:30 ` [pve-devel] [PATCH v3 storage 1/9] storage: add new find_free_volname Aaron Lauterer
2021-10-27 10:33 ` Fabian Ebner
2021-10-21 11:30 ` [pve-devel] [PATCH v3 storage 2/9] add disk rename feature Aaron Lauterer
2021-10-27 10:34 ` Fabian Ebner
2021-10-21 11:30 ` [pve-devel] [PATCH v3 qemu-server 3/9] cli: qm: change move_disk to move-disk Aaron Lauterer
2021-10-21 11:30 ` [pve-devel] [PATCH v3 qemu-server 4/9] Drive: add valid_drive_names_with_unused Aaron Lauterer
2021-10-21 11:30 ` [pve-devel] [PATCH v3 qemu-server 5/9] api: move-disk: add move to other VM Aaron Lauterer
2021-10-27 10:59 ` Fabian Ebner
2021-10-21 11:30 ` Aaron Lauterer [this message]
2021-10-21 11:30 ` [pve-devel] [PATCH v3 container 7/9] cli: pct: change move_volume to move-volume Aaron Lauterer
2021-10-21 11:30 ` [pve-devel] [PATCH v3 container 8/9] api: move-volume: add move to another container Aaron Lauterer
2021-10-27 11:44 ` Fabian Ebner
2021-10-21 11:30 ` [pve-devel] [PATCH v3 container 9/9] api: move-volume: cleanup very long lines Aaron Lauterer
2021-10-27 11:55 ` [pve-devel] [PATCH v3 storage qemu-server container 0/9] move disk or volume to other guests Fabian Ebner
2021-11-02 14:36 ` Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211021113030.2649985-7-a.lauterer@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox