From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES storage/guest-common/manager] Follow-up for fixing replication/rollback interaction
Date: Tue, 19 Oct 2021 09:54:49 +0200 [thread overview]
Message-ID: <20211019075459.14328-1-f.ebner@proxmox.com> (raw)
Returning more information about snapshots allows for better decisions
when picking the incremental base snapshot. Namely, to distinguish
between different snapshots with the same name, and to choose a more
recent snapshot in some cases, reducing the send delta. On top of
that, the code in find_common_replication_snapshot becomes simpler.
Mostly as discussed off-list with Fabian G., but instead of just
changing the return type of volume_snapshot_list, it has been replaced
with a new function. I felt like that would allow for a cleaner break
and the old name was not fully accurate anymore.
Applies on top of the original series:
https://lists.proxmox.com/pipermail/pve-devel/2021-August/049699.html
Dependencies/breaks:
1. pve-guest-common (except patch #1) depends on pve-storage patch #1.
2. pve-storage patch #2 breaks old pve-guest-common.
3. pve-guest-common patch #2 build-breaks old pve-manager.
4. pve-manager patch #3 build-depends on pve-guest-common patch #2.
pve-storage:
Fabian Ebner (3):
plugin: add volume_snapshot_info function
plugin: remove volume_snapshot_list
bump APIVER and APIAGE
ApiChangeLog | 16 ++++++++++++++++
PVE/Storage.pm | 21 +++++++--------------
PVE/Storage/Plugin.pm | 11 ++++++-----
PVE/Storage/ZFSPlugin.pm | 6 ------
PVE/Storage/ZFSPoolPlugin.pm | 23 ++++++++++++++++++-----
5 files changed, 47 insertions(+), 30 deletions(-)
pve-guest-common:
Fabian Ebner (4):
replication: refactor finding most recent common replication snapshot
replication: prepare: return additional information about snapshots
replication: find common snapshot: use additional information
config: snapshot delete check: use volume_snapshot_info
src/PVE/AbstractConfig.pm | 4 +--
src/PVE/Replication.pm | 73 ++++++++++++++++++---------------------
2 files changed, 36 insertions(+), 41 deletions(-)
pve-manager:
Fabian Ebner (3):
test: replication: avoid implicit return for volume_snapshot
test: replication: mock volume_snapshot_info
test: replication: remove mocking for obsolete volume_snapshot_list
test/ReplicationTestEnv.pm | 40 +++++++++++++++++++++++---------------
1 file changed, 24 insertions(+), 16 deletions(-)
--
2.30.2
next reply other threads:[~2021-10-19 7:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 7:54 Fabian Ebner [this message]
2021-10-19 7:54 ` [pve-devel] [PATCH storage 1/3] plugin: add volume_snapshot_info function Fabian Ebner
2021-10-19 7:54 ` [pve-devel] [PATCH storage 2/3] plugin: remove volume_snapshot_list Fabian Ebner
2021-10-19 7:54 ` [pve-devel] [PATCH storage 3/3] bump APIVER and APIAGE Fabian Ebner
2021-10-19 7:54 ` [pve-devel] [PATCH guest-common 1/4] replication: refactor finding most recent common replication snapshot Fabian Ebner
2021-10-19 7:54 ` [pve-devel] [PATCH guest-common 2/4] replication: prepare: return additional information about snapshots Fabian Ebner
2021-10-19 7:54 ` [pve-devel] [PATCH guest-common 3/4] replication: find common snapshot: use additional information Fabian Ebner
2021-10-19 7:54 ` [pve-devel] [RFC guest-common 4/4] config: snapshot delete check: use volume_snapshot_info Fabian Ebner
2021-10-19 7:54 ` [pve-devel] [PATCH manager 1/3] test: replication: avoid implicit return for volume_snapshot Fabian Ebner
2021-10-19 7:54 ` [pve-devel] [PATCH manager 2/3] test: replication: mock volume_snapshot_info Fabian Ebner
2021-10-19 7:54 ` [pve-devel] [PATCH manager 3/3] test: replication: remove mocking for obsolete volume_snapshot_list Fabian Ebner
2021-11-09 16:50 ` [pve-devel] applied-series: [PATCH-SERIES storage/guest-common/manager] Follow-up for fixing replication/rollback interaction Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211019075459.14328-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox