public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH qemu-server] api/move_disk: log deletion of source volume
@ 2021-10-18  8:24 Dominik Csapak
  0 siblings, 0 replies; only message in thread
From: Dominik Csapak @ 2021-10-18  8:24 UTC (permalink / raw)
  To: pve-devel

This way the user always sees that the source was deleted, even
if the storage plugin does not log anything (not every storage plugin
does).

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 PVE/API2/Qemu.pm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/PVE/API2/Qemu.pm b/PVE/API2/Qemu.pm
index cc2a543..d457421 100644
--- a/PVE/API2/Qemu.pm
+++ b/PVE/API2/Qemu.pm
@@ -3446,9 +3446,11 @@ __PACKAGE__->register_method({
                 }
 
 		if ($param->{delete}) {
+		    warn "removing source volume '$old_volid'\n";
 		    eval {
 			PVE::Storage::deactivate_volumes($storecfg, [$old_volid]);
 			PVE::Storage::vdisk_free($storecfg, $old_volid);
+			warn "source volume successfully removed\n";
 		    };
 		    warn $@ if $@;
 		}
-- 
2.30.2





^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-10-18  8:25 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-18  8:24 [pve-devel] [PATCH qemu-server] api/move_disk: log deletion of source volume Dominik Csapak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal