public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Reiter <s.reiter@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 2/3] ui: SystemEdit: promote advanced settings to normal
Date: Mon, 11 Oct 2021 14:55:19 +0200	[thread overview]
Message-ID: <20211011125520.1124937-3-s.reiter@proxmox.com> (raw)
In-Reply-To: <20211011125520.1124937-1-s.reiter@proxmox.com>

and reorder the panel a bit, as otherwise I found it *very* cluttered.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---
 www/manager6/qemu/SystemEdit.js | 50 +++++++++++++++------------------
 1 file changed, 22 insertions(+), 28 deletions(-)

diff --git a/www/manager6/qemu/SystemEdit.js b/www/manager6/qemu/SystemEdit.js
index 362365a9..8d178f06 100644
--- a/www/manager6/qemu/SystemEdit.js
+++ b/www/manager6/qemu/SystemEdit.js
@@ -69,28 +69,15 @@ Ext.define('PVE.qemu.SystemInputPanel', {
 	    comboItems: PVE.Utils.kvm_vga_driver_array(),
 	},
 	{
-	    xtype: 'proxmoxcheckbox',
-	    name: 'agent',
-	    uncheckedValue: 0,
-	    defaultValue: 0,
-	    deleteDefaultValue: true,
-	    fieldLabel: gettext('Qemu Agent'),
-	},
-    ],
-
-    column2: [
-	{
-	    xtype: 'pveScsiHwSelector',
-	    name: 'scsihw',
+	    xtype: 'proxmoxKVComboBox',
+	    name: 'machine',
 	    value: '__default__',
-	    bind: {
-		value: '{current.scsihw}',
-	    },
-	    fieldLabel: gettext('SCSI Controller'),
+	    fieldLabel: gettext('Machine'),
+	    comboItems: [
+		['__default__', PVE.Utils.render_qemu_machine('')],
+		['q35', 'q35'],
+	    ],
 	},
-    ],
-
-    advancedColumn1: [
 	{
 	    xtype: 'pveQemuBiosSelector',
 	    name: 'bios',
@@ -126,16 +113,23 @@ Ext.define('PVE.qemu.SystemInputPanel', {
 	},
     ],
 
-    advancedColumn2: [
+    column2: [
 	{
-	    xtype: 'proxmoxKVComboBox',
-	    name: 'machine',
+	    xtype: 'pveScsiHwSelector',
+	    name: 'scsihw',
 	    value: '__default__',
-	    fieldLabel: gettext('Machine'),
-	    comboItems: [
-		['__default__', PVE.Utils.render_qemu_machine('')],
-		['q35', 'q35'],
-	    ],
+	    bind: {
+		value: '{current.scsihw}',
+	    },
+	    fieldLabel: gettext('SCSI Controller'),
+	},
+	{
+	    xtype: 'proxmoxcheckbox',
+	    name: 'agent',
+	    uncheckedValue: 0,
+	    defaultValue: 0,
+	    deleteDefaultValue: true,
+	    fieldLabel: gettext('Qemu Agent'),
 	},
 	{
 	    xtype: 'proxmoxcheckbox',
-- 
2.30.2





  parent reply	other threads:[~2021-10-11 12:55 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-11 12:55 [pve-devel] [PATCH 0/3] Windows 11 OS type and UI improvements Stefan Reiter
2021-10-11 12:55 ` [pve-devel] [PATCH qemu-server 1/3] ostype: support Windows 11/Server 2022 Stefan Reiter
2021-10-18  7:54   ` [pve-devel] applied: " Thomas Lamprecht
2021-10-18  8:00   ` Thomas Lamprecht
2021-10-11 12:55 ` Stefan Reiter [this message]
2021-10-21 11:51   ` [pve-devel] applied: [PATCH manager 2/3] ui: SystemEdit: promote advanced settings to normal Thomas Lamprecht
2021-11-03 13:02     ` Dominik Csapak
2021-11-03 13:26       ` Thomas Lamprecht
2021-10-11 12:55 ` [pve-devel] [PATCH manager 3/3] ui: add 'win11' ostype and set defaults in wizard Stefan Reiter
2021-10-18  5:57   ` DERUMIER, Alexandre
2021-10-18  7:10     ` Thomas Lamprecht
2021-10-19  9:19       ` DERUMIER, Alexandre
2021-10-21 11:52   ` [pve-devel] applied: " Thomas Lamprecht
2021-10-12 13:51 ` [pve-devel] [PATCH 0/3] Windows 11 OS type and UI improvements Aaron Lauterer
2021-10-12 15:24   ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211011125520.1124937-3-s.reiter@proxmox.com \
    --to=s.reiter@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal