* [pve-devel] [PATCH manager] ui: storage/PBSEdit: add port field
@ 2021-10-07 12:42 Lorenz Stechauner
2021-10-07 12:55 ` Thomas Lamprecht
0 siblings, 1 reply; 3+ messages in thread
From: Lorenz Stechauner @ 2021-10-07 12:42 UTC (permalink / raw)
To: pve-devel
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
---
www/manager6/storage/PBSEdit.js | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBSEdit.js
index fcbc9548..0d7b8033 100644
--- a/www/manager6/storage/PBSEdit.js
+++ b/www/manager6/storage/PBSEdit.js
@@ -465,6 +465,13 @@ Ext.define('PVE.storage.PBSInputPanel', {
fieldLabel: gettext('Server'),
allowBlank: false,
},
+ {
+ xtype: me.isCreate ? 'numberfield' : 'displayfield',
+ name: 'port',
+ value: 8007,
+ fieldLabel: gettext('Port'),
+ allowBlank: false,
+ },
{
xtype: me.isCreate ? 'textfield' : 'displayfield',
name: 'username',
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pve-devel] [PATCH manager] ui: storage/PBSEdit: add port field
2021-10-07 12:42 [pve-devel] [PATCH manager] ui: storage/PBSEdit: add port field Lorenz Stechauner
@ 2021-10-07 12:55 ` Thomas Lamprecht
2021-10-07 12:58 ` Thomas Lamprecht
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Lamprecht @ 2021-10-07 12:55 UTC (permalink / raw)
To: Proxmox VE development discussion, Lorenz Stechauner
there are a few ways to implement that and the commit message gives zero reasoning
about the chosen one, I do not really like that...
why not allowing one to enter it as suffix in the host field like we do in PBS for
the remotes.
An extra field is always distracting for newer users as it's yet another choice one can possible make,
On 07.10.21 14:42, Lorenz Stechauner wrote:
> Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
> ---
> www/manager6/storage/PBSEdit.js | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/www/manager6/storage/PBSEdit.js b/www/manager6/storage/PBSEdit.js
> index fcbc9548..0d7b8033 100644
> --- a/www/manager6/storage/PBSEdit.js
> +++ b/www/manager6/storage/PBSEdit.js
> @@ -465,6 +465,13 @@ Ext.define('PVE.storage.PBSInputPanel', {
> fieldLabel: gettext('Server'),
> allowBlank: false,
> },
> + {
> + xtype: me.isCreate ? 'numberfield' : 'displayfield',
> + name: 'port',
> + value: 8007,
> + fieldLabel: gettext('Port'),
> + allowBlank: false,
> + },
> {
> xtype: me.isCreate ? 'textfield' : 'displayfield',
> name: 'username',
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [pve-devel] [PATCH manager] ui: storage/PBSEdit: add port field
2021-10-07 12:55 ` Thomas Lamprecht
@ 2021-10-07 12:58 ` Thomas Lamprecht
0 siblings, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2021-10-07 12:58 UTC (permalink / raw)
To: Proxmox VE development discussion, Lorenz Stechauner
On 07.10.21 14:55, Thomas Lamprecht wrote:
> there are a few ways to implement that and the commit message gives zero reasoning
> about the chosen one, I do not really like that...
>
> why not allowing one to enter it as suffix in the host field like we do in PBS for
> the remotes.
>
> An extra field is always distracting for newer users as it's yet another choice one can possible make,
argh, hit send to early... but anyhow, its something that most users won't care,
so it should be in the advanced or (preferred) extracted from the hosts, we already
have a vtype for host-with-port (its not called that but not too hard to find)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-07 13:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-10-07 12:42 [pve-devel] [PATCH manager] ui: storage/PBSEdit: add port field Lorenz Stechauner
2021-10-07 12:55 ` Thomas Lamprecht
2021-10-07 12:58 ` Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox