From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH qemu-server] drives: expose 'readonly' flag of qemu
Date: Tue, 28 Sep 2021 09:48:15 +0200 [thread overview]
Message-ID: <20210928074815.1137033-1-d.csapak@proxmox.com> (raw)
this allows a user to set a drive to read only. This can be useful
if a disk should not be written to, or if the backing file/source is
not writable (like a mapped pbs backup to /dev/loopX).
while this could also be achieved by setting 'snapshot=1', this would
create a temporary file in /var/tmp which can get quite big.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
while forward migration (old->new) worked without issue, i noticed that
when migrating backwards (new->old), the stack lets us do it, but
ignores 'invalid' disk and thus crashes on resume and the disk
is removed from the config.
i am aware that we do not support new->old migration, but is there a way
to handle such sitations more gracefully? shouldn't we deny a start
(at least on migration) for invalid configs instead of ignoring such
lines?
PVE/QemuServer.pm | 10 ++++++----
PVE/QemuServer/Drive.pm | 5 +++++
2 files changed, 11 insertions(+), 4 deletions(-)
diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index 0fb8628..5209f51 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -1569,10 +1569,12 @@ sub print_drive_commandline_full {
$opts .= ",$o=$drive->{$o}" if defined($drive->{$o});
}
- # snapshot only accepts on|off
- if (defined($drive->{snapshot})) {
- my $v = $drive->{snapshot} ? 'on' : 'off';
- $opts .= ",snapshot=$v";
+ # some options only accepts on|off
+ foreach my $o (qw(snapshot readonly)) {
+ if (defined($drive->{$o})) {
+ my $v = $drive->{$o} ? 'on' : 'off';
+ $opts .= ",$o=$v";
+ }
}
foreach my $type (['', '-total'], [_rd => '-read'], [_wr => '-write']) {
diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
index 5110190..c20e74d 100644
--- a/PVE/QemuServer/Drive.pm
+++ b/PVE/QemuServer/Drive.pm
@@ -97,6 +97,11 @@ my %drivedesc_base = (
description => "Whether the drive should be included when making backups.",
optional => 1,
},
+ readonly => {
+ type => 'boolean',
+ description => "Whether the drive is read-only.",
+ optional => 1,
+ },
replicate => {
type => 'boolean',
description => 'Whether the drive should considered for replication jobs.',
--
2.30.2
next reply other threads:[~2021-09-28 7:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-28 7:48 Dominik Csapak [this message]
2021-09-28 7:51 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210928074815.1137033-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox