public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Alexandre Derumier <aderumier@odiso.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH pve-common 0/2] add disable bridge learning feature
Date: Fri, 24 Sep 2021 10:48:53 +0200	[thread overview]
Message-ID: <20210924084855.3074162-1-aderumier@odiso.com> (raw)

Currently, if bridge receive an unknown dest mac (network bug/attack/..),
we are flooding packets to all bridge ports.

This can waste cpu time, even more with firewall enabled.
Also, if firewall is used with reject action, the src mac of RST
packet is the original unknown dest mac.
(This can block the server at Hetzner for example)

So, we can disable learning && unicast_flood on tap|veth|fwln port interface.
Then mac address need to be add statically in bridge fdb.


Alexandre Derumier (2):
  network: add support for disabling bridge learning on tap|veth|fwln
    ports
  Inotify: add bridge-disable-mac-learning option to bridges.

 src/PVE/INotify.pm |  4 +++-
 src/PVE/Network.pm | 60 +++++++++++++++++++++++++++++++++++++++++-----
 2 files changed, 57 insertions(+), 7 deletions(-)

-- 
2.30.2




             reply	other threads:[~2021-09-24  8:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-24  8:48 Alexandre Derumier [this message]
2021-09-24  8:48 ` [pve-devel] [PATCH pve-common 1/2] network: add support for disabling bridge learning on tap|veth|fwln ports Alexandre Derumier
2021-09-24  8:48 ` [pve-devel] [PATCH pve-common 2/2] Inotify: add bridge-disable-mac-learning option to bridges Alexandre Derumier
2021-11-11 10:40 ` [pve-devel] [PATCH pve-common 0/2] add disable bridge learning feature Thomas Lamprecht
2021-11-11 10:46   ` Josef Johansson
2021-11-11 18:38   ` DERUMIER, Alexandre
2022-03-16 16:33 ` [pve-devel] applied-series: " Thomas Lamprecht
2022-03-16 16:43   ` DERUMIER, Alexandre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210924084855.3074162-1-aderumier@odiso.com \
    --to=aderumier@odiso.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal