public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Reiter <s.reiter@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC v2 0/4] Initial TPM support for VMs
Date: Thu, 23 Sep 2021 16:54:55 +0200	[thread overview]
Message-ID: <20210923145459.1508558-1-s.reiter@proxmox.com> (raw)

Makes Windows 11 (test build) happy: https://i.imgur.com/kZ0Mpnr.jpeg

Tested under Linux as well, works with (updated) OVMF and SeaBIOS, though
SeaBIOS requires clearing via the BIOS setup screen and may not support all
features it seems (e.g. Windows shows the TPM, but doesn't allow BitLocker,
presumably because it requires UEFI).

Requires patched swtpm with my PR applied:
https://github.com/stefanberger/swtpm/pull/513

= Known Issues =

Backups currently don't work. This is due to the fact that we use QEMU to write
out all data - but QEMU doesn't know about the backing store of swtpm.  This is
quite an issue, and I'm not yet sure how to best handle it. We could include the
TPM as a "blob" like the config (as it's fairly small), but I need to think
through the timing so consistency is not affected.

swtpm_setup doesn't support the backing-uri parameter correctly yet (see also
the PR for a bit more info), which means we can't generate the initial TPM state
to our liking yet. This doesn't seem to affect operation much, but is not the
recommended and documented way of using swtpm.

TPM state cannot be stored on non-krbd Ceph, as RBD user-space support is not
implemented in swtpm (yet). Workaround would be to always enable krbd for TPM
state volumes. This is an issue in general, as swtpm currently only works with
files/devices that have an entry in the file system hierarchy.

An interesting way around some of these issues would be NDB support in swtpm and
accessing the backing store via QEMU's driver stack.


RFC v1 -> RFC v2:
* with the above PR, we can store state in a single file/block device, thus we
  can treat it similar to an efidisk - this eliminates any concerns about
  storing on pmxcfs
* always allocate the state as 4 MiB (on directory storage it might auto-shrink)
* fixes migration, since source and destination are now different
* add GUI patch


edk2-firmware: Stefan Reiter (1):
  enable TPM and TPM2 support

 debian/rules | 4 ++++
 1 file changed, 4 insertions(+)

storage: Stefan Reiter (1):
  import: don't check for 1K aligned size

 PVE/Storage/Plugin.pm | 1 -
 1 file changed, 1 deletion(-)

qemu-server: Stefan Reiter (1):
  fix #3075: add TPM v1.2 and v2.0 support via swtpm

 PVE/API2/Qemu.pm        |   5 ++
 PVE/QemuMigrate.pm      |  14 ++++-
 PVE/QemuServer.pm       | 135 +++++++++++++++++++++++++++++++++++++---
 PVE/QemuServer/Drive.pm |  63 +++++++++++++++----
 4 files changed, 198 insertions(+), 19 deletions(-)

manager: Stefan Reiter (1):
  ui: add support for adding TPM devices

 www/manager6/Makefile                    |  1 +
 www/manager6/Utils.js                    |  2 +-
 www/manager6/form/DiskStorageSelector.js |  5 +-
 www/manager6/qemu/HDMove.js              |  1 +
 www/manager6/qemu/HDTPM.js               | 88 ++++++++++++++++++++++++
 www/manager6/qemu/HardwareView.js        | 25 ++++++-
 6 files changed, 119 insertions(+), 3 deletions(-)
 create mode 100644 www/manager6/qemu/HDTPM.js

-- 
2.30.2




             reply	other threads:[~2021-09-23 14:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-23 14:54 Stefan Reiter [this message]
2021-09-23 14:54 ` [pve-devel] [RFC v2 edk2-firmware 1/4] enable TPM and TPM2 support Stefan Reiter
2021-09-23 15:07   ` [pve-devel] applied: " Thomas Lamprecht
2021-09-23 14:54 ` [pve-devel] [RFC v2 storage 2/4] import: don't check for 1K aligned size Stefan Reiter
2021-09-23 14:54 ` [pve-devel] [RFC v2 qemu-server 3/4] fix #3075: add TPM v1.2 and v2.0 support via swtpm Stefan Reiter
2021-09-23 14:54 ` [pve-devel] [RFC v2 manager 4/4] ui: add support for adding TPM devices Stefan Reiter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210923145459.1508558-1-s.reiter@proxmox.com \
    --to=s.reiter@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal