public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 manager 3/4] ui: cluster backup: only restrict storages to node when it's selected
Date: Tue, 21 Sep 2021 13:22:07 +0200	[thread overview]
Message-ID: <20210921112208.48084-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210921112208.48084-1-f.ebner@proxmox.com>

Previously, only the storages for the local node would be shown, which
prevented configuring a job for remote nodes when the storage is not
available on the local node.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---

Changes from v1:
    * Use a separate patch for this.
    * Use the clusterView option.

 www/manager6/dc/Backup.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index 0293c099..adefc5f4 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -56,7 +56,7 @@ Ext.define('PVE.dc.BackupEdit', {
 
 	let storagesel = Ext.create('PVE.form.StorageSelector', {
 	    fieldLabel: gettext('Storage'),
-	    nodename: 'localhost',
+	    clusterView: true,
 	    storageContent: 'backup',
 	    allowBlank: false,
 	    name: 'storage',
@@ -159,7 +159,7 @@ Ext.define('PVE.dc.BackupEdit', {
 	    emptyText: '-- ' + gettext('All') + ' --',
 	    listeners: {
 		change: function(f, value) {
-		    storagesel.setNodename(value || 'localhost');
+		    storagesel.setNodename(value);
 		    let mode = selModeField.getValue();
 		    store.clearFilter();
 		    store.filterBy(function(rec) {
-- 
2.30.2





  parent reply	other threads:[~2021-09-21 11:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-21 11:22 [pve-devel] [PATCH-SERIES v2 manager] ui: some backup job improvements Fabian Ebner
2021-09-21 11:22 ` [pve-devel] [PATCH v2 manager 1/4] ui: storage selector: only check for nodename before loading storage Fabian Ebner
2021-09-21 11:22 ` [pve-devel] [PATCH v2 manager 2/4] ui: storage selector: add new clusterView option Fabian Ebner
2021-09-21 11:22 ` Fabian Ebner [this message]
2021-09-21 11:22 ` [pve-devel] [PATCH v2 manager 4/4] ui: storage selector: use storage type renderer Fabian Ebner
2021-09-21 13:31 ` [pve-devel] applied-series-partially: [PATCH-SERIES v2 manager] ui: some backup job improvements Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210921112208.48084-4-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal