From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 07/10] ui: qemu/OSTypeEdit: drop throwing an error on multiple widgets
Date: Mon, 20 Sep 2021 14:23:35 +0200 [thread overview]
Message-ID: <20210920122338.840436-8-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210920122338.840436-1-d.csapak@proxmox.com>
we will have multiple panels with the same widget. Instead
of raising an error in that case, simply ignore it, since
we normally only want to set the default initially, not when
users configured something else
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/qemu/OSTypeEdit.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/qemu/OSTypeEdit.js b/www/manager6/qemu/OSTypeEdit.js
index 438d7c6b..fad56e8a 100644
--- a/www/manager6/qemu/OSTypeEdit.js
+++ b/www/manager6/qemu/OSTypeEdit.js
@@ -37,7 +37,7 @@ Ext.define('PVE.qemu.OSTypeInputPanel', {
if (widgets.length === 1) {
widgets[0].setValue(newValue);
} else {
- throw 'non unique widget :' + widget + ' in Wizard';
+ // ignore multiple disks, we only want to set the type if there is a single disk
}
},
},
--
2.30.2
next prev parent reply other threads:[~2021-09-20 12:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:23 [pve-devel] [PATCH manager 00/10] multi tab disk panel & multi disk wizard Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 01/10] ui: qemu/HDEdit: move Bandwidth options to a different tab Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 02/10] ui: form/ControllerSelector: set correct max value for the device-id Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 03/10] ui: refactor sortByPreviousUsage and nextFreeDisk Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 04/10] ui: form/ControllerSelector: add updateVMConfig and getConfId Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 05/10] ui: qemu/HDEdit: use me instead of this Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 06/10] ui: qemu/HDEdit: fire an event when the disk id changes Dominik Csapak
2021-09-20 12:23 ` Dominik Csapak [this message]
2021-09-20 12:23 ` [pve-devel] [PATCH manager 08/10] ui: Utils: add capture group for the id in bus_match Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 09/10] ui: form/ControllerSelector: add option for selecting free on inital config Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 10/10] ui: add qemu/MultiHDEdit and use it in the wizard Dominik Csapak
2021-09-21 13:46 ` [pve-devel] [PATCH manager 00/10] multi tab disk panel & multi disk wizard Lorenz Stechauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920122338.840436-8-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox