From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 02/10] ui: form/ControllerSelector: set correct max value for the device-id
Date: Mon, 20 Sep 2021 14:23:30 +0200 [thread overview]
Message-ID: <20210920122338.840436-3-d.csapak@proxmox.com> (raw)
In-Reply-To: <20210920122338.840436-1-d.csapak@proxmox.com>
the 'diskControllerMaxIDs' object in Utils does not describe the
'maximum ids', but the maximum *number* of ids, so the max is one less
correctly set that instead
the api rejected those values (e.g. ide4) already, so its only a ui change
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/form/ControllerSelector.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/form/ControllerSelector.js b/www/manager6/form/ControllerSelector.js
index daca2432..27c06169 100644
--- a/www/manager6/form/ControllerSelector.js
+++ b/www/manager6/form/ControllerSelector.js
@@ -95,7 +95,7 @@ Ext.define('PVE.form.ControllerSelector', {
return;
}
let field = me.down('field[name=deviceid]');
- field.setMaxValue(PVE.Utils.diskControllerMaxIDs[value]);
+ field.setMaxValue(PVE.Utils.diskControllerMaxIDs[value] - 1);
field.validate();
},
},
@@ -104,7 +104,7 @@ Ext.define('PVE.form.ControllerSelector', {
xtype: 'proxmoxintegerfield',
name: 'deviceid',
minValue: 0,
- maxValue: PVE.Utils.diskControllerMaxIDs.ide,
+ maxValue: PVE.Utils.diskControllerMaxIDs.ide - 1,
value: '0',
flex: 1,
allowBlank: false,
--
2.30.2
next prev parent reply other threads:[~2021-09-20 12:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:23 [pve-devel] [PATCH manager 00/10] multi tab disk panel & multi disk wizard Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 01/10] ui: qemu/HDEdit: move Bandwidth options to a different tab Dominik Csapak
2021-09-20 12:23 ` Dominik Csapak [this message]
2021-09-20 12:23 ` [pve-devel] [PATCH manager 03/10] ui: refactor sortByPreviousUsage and nextFreeDisk Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 04/10] ui: form/ControllerSelector: add updateVMConfig and getConfId Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 05/10] ui: qemu/HDEdit: use me instead of this Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 06/10] ui: qemu/HDEdit: fire an event when the disk id changes Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 07/10] ui: qemu/OSTypeEdit: drop throwing an error on multiple widgets Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 08/10] ui: Utils: add capture group for the id in bus_match Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 09/10] ui: form/ControllerSelector: add option for selecting free on inital config Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 10/10] ui: add qemu/MultiHDEdit and use it in the wizard Dominik Csapak
2021-09-21 13:46 ` [pve-devel] [PATCH manager 00/10] multi tab disk panel & multi disk wizard Lorenz Stechauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920122338.840436-3-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox