From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager 00/10] multi tab disk panel & multi disk wizard
Date: Mon, 20 Sep 2021 14:23:28 +0200 [thread overview]
Message-ID: <20210920122338.840436-1-d.csapak@proxmox.com> (raw)
this series is intended to replace dominics and my previous attempts
at this [0][1][2]
splits the bandwidth options into their on tab on the disk panel and
introduces a 'MultiHDEdit' panel which creates/deletes the
HDEdit panels on demand.
The UX is modeled after Dominics first attempt, but a very different
approach code-wise. instead of having a seperate 'data' panel that
contains the vm config, let the multi disk panel handle that
and pass it through to the panels below. this way the HDEdit does
not need a big code-change to get/set the config.
0: https://lists.proxmox.com/pipermail/pve-devel/2021-June/048690.html
1: https://lists.proxmox.com/pipermail/pve-devel/2021-July/049295.html
2: https://lists.proxmox.com/pipermail/pve-devel/2021-September/050013.html
Dominik Csapak (10):
ui: qemu/HDEdit: move Bandwidth options to a different tab
ui: form/ControllerSelector: set correct max value for the device-id
ui: refactor sortByPreviousUsage and nextFreeDisk
ui: form/ControllerSelector: add updateVMConfig and getConfId
ui: qemu/HDEdit: use me instead of this
ui: qemu/HDEdit: fire an event when the disk id changes
ui: qemu/OSTypeEdit: drop throwing an error on multiple widgets
ui: Utils: add capture group for the id in bus_match
ui: form/ControllerSelector: add option for selecting free on inital
config
ui: add qemu/MultiHDEdit and use it in the wizard
www/manager6/Makefile | 1 +
www/manager6/Utils.js | 48 +++-
www/manager6/form/ControllerSelector.js | 65 +++---
www/manager6/qemu/CreateWizard.js | 4 +-
www/manager6/qemu/HDEdit.js | 143 ++++++++----
www/manager6/qemu/MultiHDEdit.js | 291 ++++++++++++++++++++++++
www/manager6/qemu/OSTypeEdit.js | 2 +-
www/manager6/window/Wizard.js | 5 +-
8 files changed, 477 insertions(+), 82 deletions(-)
create mode 100644 www/manager6/qemu/MultiHDEdit.js
--
2.30.2
next reply other threads:[~2021-09-20 12:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:23 Dominik Csapak [this message]
2021-09-20 12:23 ` [pve-devel] [PATCH manager 01/10] ui: qemu/HDEdit: move Bandwidth options to a different tab Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 02/10] ui: form/ControllerSelector: set correct max value for the device-id Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 03/10] ui: refactor sortByPreviousUsage and nextFreeDisk Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 04/10] ui: form/ControllerSelector: add updateVMConfig and getConfId Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 05/10] ui: qemu/HDEdit: use me instead of this Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 06/10] ui: qemu/HDEdit: fire an event when the disk id changes Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 07/10] ui: qemu/OSTypeEdit: drop throwing an error on multiple widgets Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 08/10] ui: Utils: add capture group for the id in bus_match Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 09/10] ui: form/ControllerSelector: add option for selecting free on inital config Dominik Csapak
2021-09-20 12:23 ` [pve-devel] [PATCH manager 10/10] ui: add qemu/MultiHDEdit and use it in the wizard Dominik Csapak
2021-09-21 13:46 ` [pve-devel] [PATCH manager 00/10] multi tab disk panel & multi disk wizard Lorenz Stechauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210920122338.840436-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox