public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Stefan Reiter <s.reiter@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] fix #3629: ui: rng: increase default ratelimit to 2048 B/s
Date: Mon, 20 Sep 2021 10:55:51 +0200	[thread overview]
Message-ID: <20210920085551.48298-1-s.reiter@proxmox.com> (raw)

FreeBSD 13 VMs will bug out and consume loads of idle CPU time if the
ratelimit is 1024 B/s or lower. Increasing to 2048 fixes the issue,
confirmed experimentally, and doesn't seem much worse as a default.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
---

On the one hand this *really* sounds like a FreeBSD bug to me, even reading
through their bugtracker linked from the report in ours.

But on the other, 2048 doesn't sound much worse as a limit either, and since
this appears to be a rather new bug I think it's enough to change it in the GUI
and avoid any hassle with API default changes.

An "ostype" for BSDs might be nice too I suppose. Not sure "Other" would cover
this, I personally use "Linux" for my BSD VMs...

 www/manager6/qemu/RNGEdit.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/qemu/RNGEdit.js b/www/manager6/qemu/RNGEdit.js
index e34e2c08..84fdf585 100644
--- a/www/manager6/qemu/RNGEdit.js
+++ b/www/manager6/qemu/RNGEdit.js
@@ -63,7 +63,7 @@ Ext.define('PVE.qemu.RNGInputPanel', {
 	name: 'max_bytes',
 	minValue: 0,
 	step: 1,
-	value: 1024,
+	value: 2048,
 	fieldLabel: gettext('Limit (Bytes/Period)'),
 	labelWidth: 130,
 	emptyText: gettext('unlimited'),
-- 
2.30.2





                 reply	other threads:[~2021-09-20  8:56 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210920085551.48298-1-s.reiter@proxmox.com \
    --to=s.reiter@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal