* [pve-devel] [PATCH storage 0/1] fix #3609 add support to SMB3_11 @ 2021-09-13 12:15 Moayad Almalat 2021-09-13 12:15 ` [pve-devel] [PATCH storage 1/1] " Moayad Almalat 0 siblings, 1 reply; 4+ messages in thread From: Moayad Almalat @ 2021-09-13 12:15 UTC (permalink / raw) To: pve-devel Added support for the SMB version SMB3_11 When the `min protocol = SMB3_11` in the smb.conf, the CIFS mount will return with the following error: ``` CIFS VFS: cifs_mount failed w/return code = -95 ``` added an optional option to use the `vers=3.11` PVE/Storage/CIFSPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.30.2 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] [PATCH storage 1/1] fix #3609 add support to SMB3_11 2021-09-13 12:15 [pve-devel] [PATCH storage 0/1] fix #3609 add support to SMB3_11 Moayad Almalat @ 2021-09-13 12:15 ` Moayad Almalat 2021-09-14 8:31 ` Fabian Ebner 2021-09-15 9:06 ` [pve-devel] applied: " Thomas Lamprecht 0 siblings, 2 replies; 4+ messages in thread From: Moayad Almalat @ 2021-09-13 12:15 UTC (permalink / raw) To: pve-devel --- PVE/Storage/CIFSPlugin.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm index be06cc7..d4a517d 100644 --- a/PVE/Storage/CIFSPlugin.pm +++ b/PVE/Storage/CIFSPlugin.pm @@ -120,7 +120,7 @@ sub properties { smbversion => { description => "SMB protocol version", type => 'string', - enum => ['2.0', '2.1', '3.0'], + enum => ['2.0', '2.1', '3.0', '3.11'], optional => 1, }, }; -- 2.30.2 ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH storage 1/1] fix #3609 add support to SMB3_11 2021-09-13 12:15 ` [pve-devel] [PATCH storage 1/1] " Moayad Almalat @ 2021-09-14 8:31 ` Fabian Ebner 2021-09-15 9:06 ` [pve-devel] applied: " Thomas Lamprecht 1 sibling, 0 replies; 4+ messages in thread From: Fabian Ebner @ 2021-09-14 8:31 UTC (permalink / raw) To: pve-devel, m.almalat Works for me. Configuring 'smbversion 3.11' when the server has 'min protocol = SMB3' or 'min protocol = SMB3_11' makes mounting the CIFS possible again. Tested-by: Fabian Ebner <f.ebner@proxmox.com> Am 13.09.21 um 14:15 schrieb Moayad Almalat: > --- > PVE/Storage/CIFSPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm > index be06cc7..d4a517d 100644 > --- a/PVE/Storage/CIFSPlugin.pm > +++ b/PVE/Storage/CIFSPlugin.pm > @@ -120,7 +120,7 @@ sub properties { > smbversion => { > description => "SMB protocol version", > type => 'string', > - enum => ['2.0', '2.1', '3.0'], > + enum => ['2.0', '2.1', '3.0', '3.11'], > optional => 1, > }, > }; > ^ permalink raw reply [flat|nested] 4+ messages in thread
* [pve-devel] applied: [PATCH storage 1/1] fix #3609 add support to SMB3_11 2021-09-13 12:15 ` [pve-devel] [PATCH storage 1/1] " Moayad Almalat 2021-09-14 8:31 ` Fabian Ebner @ 2021-09-15 9:06 ` Thomas Lamprecht 1 sibling, 0 replies; 4+ messages in thread From: Thomas Lamprecht @ 2021-09-15 9:06 UTC (permalink / raw) To: Proxmox VE development discussion, Moayad Almalat On 13.09.21 14:15, Moayad Almalat wrote: missing your sign-off here, and what you wrote in the cover letter should actually be written here in the commit message, as the cover letter does not makes it into git ;) That said, single commit patches normally do not require a cover letter at all. > --- > PVE/Storage/CIFSPlugin.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > applied with Fabi's T-b tag, thanks! FYI: Fabi and I checked the whole CIFS dialect version stuff a bit closer yesterday and I went for a change from "3.0" as default to "default" which does: > default - Tries to negotiate the highest SMB2+ version supported by both the client > and server. -- man mount.cifs ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-15 9:07 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-09-13 12:15 [pve-devel] [PATCH storage 0/1] fix #3609 add support to SMB3_11 Moayad Almalat 2021-09-13 12:15 ` [pve-devel] [PATCH storage 1/1] " Moayad Almalat 2021-09-14 8:31 ` Fabian Ebner 2021-09-15 9:06 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox