[pve-devel] [PATCH storage 0/1] fix #3609 add support to SMB3_11

[pve-devel] [PATCH storage 0/1] fix #3609 add support to SMB3_11

[Moayad Almalat]

Added support for the SMB version SMB3_11 When the `min protocol =
SMB3_11` in the smb.conf, the CIFS mount will return with the
following error: 
```
CIFS VFS: cifs_mount failed w/return code = -95
```
added an optional option to use the `vers=3.11`

 PVE/Storage/CIFSPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.30.2

[pve-devel] [PATCH storage 1/1] fix #3609 add support to SMB3_11

[Moayad Almalat]

---
 PVE/Storage/CIFSPlugin.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm
index be06cc7..d4a517d 100644
--- a/PVE/Storage/CIFSPlugin.pm
+++ b/PVE/Storage/CIFSPlugin.pm
@@ -120,7 +120,7 @@ sub properties {
 	smbversion => {
 	    description => "SMB protocol version",
 	    type => 'string',
-	    enum => ['2.0', '2.1', '3.0'],
+	    enum => ['2.0', '2.1', '3.0', '3.11'],
 	    optional => 1,
 	},
     };
-- 
2.30.2

Re: [pve-devel] [PATCH storage 1/1] fix #3609 add support to SMB3_11

[Fabian Ebner]

Works for me. Configuring 'smbversion 3.11' when the server has 'min 
protocol = SMB3' or 'min protocol = SMB3_11' makes mounting the CIFS 
possible again.

Tested-by: Fabian Ebner <f.ebner@proxmox.com>

Am 13.09.21 um 14:15 schrieb Moayad Almalat:
> ---
>   PVE/Storage/CIFSPlugin.pm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm
> index be06cc7..d4a517d 100644
> --- a/PVE/Storage/CIFSPlugin.pm
> +++ b/PVE/Storage/CIFSPlugin.pm
> @@ -120,7 +120,7 @@ sub properties {
>   	smbversion => {
>   	    description => "SMB protocol version",
>   	    type => 'string',
> -	    enum => ['2.0', '2.1', '3.0'],
> +	    enum => ['2.0', '2.1', '3.0', '3.11'],
>   	    optional => 1,
>   	},
>       };
> 

[pve-devel] applied: [PATCH storage 1/1] fix #3609 add support to SMB3_11

[Thomas Lamprecht]

On 13.09.21 14:15, Moayad Almalat wrote:

missing your sign-off here, and what you wrote in the cover letter should actually
be written here in the commit message, as the cover letter does not makes it into git ;)

That said, single commit patches normally do not require a cover letter at all.

> ---
>  PVE/Storage/CIFSPlugin.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied with Fabi's T-b tag, thanks!

FYI: Fabi and I checked the whole CIFS dialect version stuff a bit closer yesterday and
I went for a change from "3.0" as default to "default" which does:

> default - Tries to negotiate the highest SMB2+ version supported by both the client
> and server.
-- man mount.cifs