public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v2 widget-toolkit 2/2] zfs detail: hide the pool itself in tree view
Date: Fri, 10 Sep 2021 13:45:37 +0200	[thread overview]
Message-ID: <20210910114538.175196-4-f.ebner@proxmox.com> (raw)
In-Reply-To: <20210910114538.175196-1-f.ebner@proxmox.com>

and show the overall health in the grid instead.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---

New in v2.

 src/window/ZFSDetail.js | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/window/ZFSDetail.js b/src/window/ZFSDetail.js
index 5606ca0..9ad46b8 100644
--- a/src/window/ZFSDetail.js
+++ b/src/window/ZFSDetail.js
@@ -78,6 +78,10 @@ Ext.define('Proxmox.window.ZFSDetail', {
 		nodename: '{nodename}',
 	    },
 	    rows: {
+		state: {
+		    header: gettext('Health'),
+		    renderer: Proxmox.Utils.render_zfs_health,
+		},
 		scan: {
 		    header: gettext('Scan'),
 		},
@@ -98,7 +102,8 @@ Ext.define('Proxmox.window.ZFSDetail', {
 	    title: gettext('Devices'),
 	    stateful: true,
 	    stateId: 'grid-node-zfsstatus',
-	    rootVisible: true,
+	    // the root is the pool itself and the information is shown by the grid
+	    rootVisible: false,
 	    fields: ['name', 'status',
 		{
 		    type: 'string',
-- 
2.30.2





  parent reply	other threads:[~2021-09-10 11:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-10 11:45 [pve-devel] [PATCH-SERIES v2 storage/widget-toolkit/manager] fix #3610: properly build ZFS detail tree Fabian Ebner
2021-09-10 11:45 ` [pve-devel] [PATCH v2 storage 1/1] " Fabian Ebner
2021-09-10 12:19   ` [pve-devel] applied: " Thomas Lamprecht
2021-09-10 11:45 ` [pve-devel] [PATCH v2 widget-toolkit 1/2] zfs detail: increase window height Fabian Ebner
2021-09-10 11:45 ` Fabian Ebner [this message]
2021-09-10 11:45 ` [pve-devel] [PATCH v2 manager 1/1] ui: node: zfs: use ZFSDetail window from widget-toolkit Fabian Ebner
2022-01-13 11:21 ` [pve-devel] [PATCH-SERIES v2 storage/widget-toolkit/manager] fix #3610: properly build ZFS detail tree Fabian Ebner
2022-01-13 11:58   ` [pve-devel] applied-series: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210910114538.175196-4-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal