From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH manager] ui: improve ACME edit/apply button visibilty
Date: Thu, 9 Sep 2021 16:36:19 +0200 [thread overview]
Message-ID: <20210909143619.2706696-1-d.csapak@proxmox.com> (raw)
multiple users were confused[0], as they did not interpret the 'icon only'
in the toolbar as a button (and it did not help that we prevented
the cursor to change)
to improve it, make the button a normal one again, and add some
text for context (this is more inline what we do elsewhere in toolbars)
0: https://forum.proxmox.com/threads/acme-over-dnschallenge-failing.71902
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/node/ACME.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/www/manager6/node/ACME.js b/www/manager6/node/ACME.js
index cfe9cc12..635787f6 100644
--- a/www/manager6/node/ACME.js
+++ b/www/manager6/node/ACME.js
@@ -365,6 +365,7 @@ Ext.define('PVE.node.ACME', {
formulas: {
canOrder: (get) => !!get('account') && get('domaincount') > 0,
editBtnIcon: (get) => 'fa black fa-' + (get('accountEditable') ? 'check' : 'pencil'),
+ editBtnText: (get) => get('accountEditable') ? gettext('Apply') : gettext('Edit'),
accountTextHidden: (get) => get('accountEditable') || !get('accountsAvailable'),
accountValueHidden: (get) => !get('accountEditable') || !get('accountsAvailable'),
},
@@ -606,10 +607,9 @@ Ext.define('PVE.node.ACME', {
{
xtype: 'button',
iconCls: 'fa black fa-pencil',
- baseCls: 'x-plain',
- userCls: 'pointer',
bind: {
iconCls: '{editBtnIcon}',
+ text: '{editBtnText}',
hidden: '{!accountsAvailable}',
},
handler: 'toggleEditAccount',
--
2.30.2
next reply other threads:[~2021-09-09 14:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-09 14:36 Dominik Csapak [this message]
2021-09-09 15:35 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210909143619.2706696-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox