[pve-devel] [PATCH manager] vzdump: include current backup when pruning dumpdir

[pve-devel] [PATCH manager] vzdump: include current backup when pruning dumpdir

[Fabian Ebner]

Not doing so leads to an off-by-one error, and pruning in a dumpdir
really should behave the same way as pruning in a storage.

Reported in the community forum:
https://forum.proxmox.com/threads/problem-mit-prune-backups.95737/

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
 PVE/VZDump.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index b671ab19..d00be8b2 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -991,7 +991,7 @@ sub exec_backup_task {
 	    debugmsg ('info', "prune older backups with retention: $keepstr", $logfd);
 	    my $pruned = 0;
 	    if (!defined($opts->{storage})) {
-		my $bklist = get_backup_file_list($opts->{dumpdir}, $bkname, $task->{target});
+		my $bklist = get_backup_file_list($opts->{dumpdir}, $bkname);
 		PVE::Storage::prune_mark_backup_group($bklist, $prune_options);
 
 		foreach my $prune_entry (@{$bklist}) {
-- 
2.30.2

[pve-devel] applied: [PATCH manager] vzdump: include current backup when pruning dumpdir

[Thomas Lamprecht]

On 07.09.21 13:18, Fabian Ebner wrote:
> Not doing so leads to an off-by-one error, and pruning in a dumpdir
> really should behave the same way as pruning in a storage.
> 
> Reported in the community forum:
> https://forum.proxmox.com/threads/problem-mit-prune-backups.95737/
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>  PVE/VZDump.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
>

applied, thanks!