public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH container] setup/centos: set /etc/locale.conf to avoid systemd-firstboot hanging
@ 2021-08-24 10:07 Oguz Bektas
  2021-08-24 11:27 ` Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Oguz Bektas @ 2021-08-24 10:07 UTC (permalink / raw)
  To: pve-devel

we can set the locale to a sane default to avoid the issue described in
forum post [0]

[0]: https://forum.proxmox.com/threads/centos-lxc-containers-require-a-reboot.94972/

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
---
 src/PVE/LXC/Setup/CentOS.pm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/PVE/LXC/Setup/CentOS.pm b/src/PVE/LXC/Setup/CentOS.pm
index 77eb6f7..fa8f862 100644
--- a/src/PVE/LXC/Setup/CentOS.pm
+++ b/src/PVE/LXC/Setup/CentOS.pm
@@ -110,6 +110,10 @@ sub template_fixup {
 	$data =~ s!^(/sbin/start_udev.*)$!#$1!gm;
 	$self->ct_file_set_contents($filename, $data);
     }
+
+    # temporary fix for systemd-firstboot
+    $self->ct_file_set_contents('/etc/locale.conf', "LANG=C.utf8");
+
     # always call so root can login, if /etc/securetty doesn't exists it's a no-op
     $self->setup_securetty($conf);
 }
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [pve-devel] [PATCH container] setup/centos: set /etc/locale.conf to avoid systemd-firstboot hanging
  2021-08-24 10:07 [pve-devel] [PATCH container] setup/centos: set /etc/locale.conf to avoid systemd-firstboot hanging Oguz Bektas
@ 2021-08-24 11:27 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-08-24 11:27 UTC (permalink / raw)
  To: Proxmox VE development discussion, Oguz Bektas

On 24/08/2021 12:07, Oguz Bektas wrote:
> we can set the locale to a sane default to avoid the issue described in
> forum post [0]
> 
> [0]: https://forum.proxmox.com/threads/centos-lxc-containers-require-a-reboot.94972/
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  src/PVE/LXC/Setup/CentOS.pm | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/PVE/LXC/Setup/CentOS.pm b/src/PVE/LXC/Setup/CentOS.pm
> index 77eb6f7..fa8f862 100644
> --- a/src/PVE/LXC/Setup/CentOS.pm
> +++ b/src/PVE/LXC/Setup/CentOS.pm
> @@ -110,6 +110,10 @@ sub template_fixup {
>  	$data =~ s!^(/sbin/start_udev.*)$!#$1!gm;
>  	$self->ct_file_set_contents($filename, $data);
>      }
> +
> +    # temporary fix for systemd-firstboot
> +    $self->ct_file_set_contents('/etc/locale.conf', "LANG=C.utf8");
> +

really should not be done if the file already exists/contains options though?
Else you potentially override customized templates, which is not nice.

>      # always call so root can login, if /etc/securetty doesn't exists it's a no-op
>      $self->setup_securetty($conf);
>  }
> 





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-24 11:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-24 10:07 [pve-devel] [PATCH container] setup/centos: set /etc/locale.conf to avoid systemd-firstboot hanging Oguz Bektas
2021-08-24 11:27 ` Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal