From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Constantin Herold <proxmox8914@herold.me>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu-server] fix #3581: pass size via argument for memory-backend-ram qmp call
Date: Tue, 17 Aug 2021 15:21:48 +0200 [thread overview]
Message-ID: <20210817132148.b5zjoct22ccm4ste@olga.proxmox.com> (raw)
In-Reply-To: <20210812181642.1818-1-proxmox8914@herold.me>
Hi,
On Thu, Aug 12, 2021 at 08:16:42PM +0200, Constantin Herold wrote:
> Signed-off-by: Constantin Herold <proxmox8914@herold.me>
> ---
> PVE/QemuServer/Memory.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/QemuServer/Memory.pm b/PVE/QemuServer/Memory.pm
> index f3e15f1..e34727f 100644
> --- a/PVE/QemuServer/Memory.pm
> +++ b/PVE/QemuServer/Memory.pm
> @@ -155,7 +155,7 @@ sub qemu_memory_hotplug {
> eval { hugepages_update_locked($code); };
>
> } else {
> - eval { mon_cmd($vmid, "object-add", 'qom-type' => "memory-backend-ram", id => "mem-$name", props => { size => int($dimm_size*1024*1024) } ) };
> + eval { mon_cmd($vmid, "object-add", 'qom-type' => "memory-backend-ram", id => "mem-$name", size => int($dimm_size*1024*1024) ) };
Looks fine.
There's another `object-add` command a few lines higher up which also
still uses `props` and needs to be changed in the same way.
Care to include it in a v2?
It would also be nice to include the cause in the commit message,
something like:
`props` was deprecated with qemu 5.0 and removed in qemu 6.0.
The commands are now generally flattened.
next prev parent reply other threads:[~2021-08-17 13:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 18:16 Constantin Herold
2021-08-17 13:21 ` Wolfgang Bumiller [this message]
2021-08-17 15:32 ` Constantin Herold
2021-08-18 6:54 ` Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817132148.b5zjoct22ccm4ste@olga.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=proxmox8914@herold.me \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox