From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH-SERIES v3] fix #3111: fix interaction of snapshot operations with replication
Date: Thu, 12 Aug 2021 13:00:59 +0200 [thread overview]
Message-ID: <20210812110111.73883-1-f.ebner@proxmox.com> (raw)
For more context, see also:
https://lists.proxmox.com/pipermail/pve-devel/2021-August/049694.html
Changes from v2:
* Many new patches, as the approach is different:
For one, only replication snapshots that are blocking rollback
are removed. Second, consider more snapshot candidates when
probing for an incremental replication base. Last, instead of
directly running replication after rollback, prevent snapshot
deletion if it might be the current incremental replication
base.
Many thanks to Fabian G. for discussing those ideas with me!
All patches are new in v3, except guest-common patch #1, which
hasn't changed much, and would fix some issues already by itself.
I think nothing requires an explicit dependency bump, but some things,
like "remove only the real blockers", will only start working when all
the pieces are in place.
storage:
Fabian Ebner (3):
zfspool: add zfs_get_sorted_snapshot_list helper
zfspool: add blockers parameter to volume_snapshot_is_possible
test: zfspool: extend some rollback is possible tests with new
blockers parameter
PVE/Storage.pm | 4 +--
PVE/Storage/BTRFSPlugin.pm | 2 +-
PVE/Storage/Plugin.pm | 5 ++-
PVE/Storage/ZFSPoolPlugin.pm | 65 +++++++++++++++-------------------
test/run_test_zfspoolplugin.pl | 65 +++++++++++++++++++++++++---------
5 files changed, 85 insertions(+), 56 deletions(-)
container:
Fabian Ebner (1):
config: rollback is possible: add blockers parameter
src/PVE/LXC/Config.pm | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
qemu-server:
Fabian Ebner (1):
config: rollback is possible: add blockers parameter
PVE/QemuConfig.pm | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
guest-common:
Fabian Ebner (7):
partially fix #3111: snapshot rollback: improve removing replication
snapshots
config: rollback: factor out helper for removing replication snapshots
partially fix #3111: further improve removing replication snapshots
replication: remove unused variable and style fixes
replication: pass guest config to find_common_replication_snapshot
partially fix #3111: replication: be less picky when selecting
incremental base
fix #3111 config: snapshot delete: check if replication still needs it
src/PVE/AbstractConfig.pm | 120 +++++++++++++++++++++++++++++++----
src/PVE/Replication.pm | 66 ++++++++++++++++----
src/PVE/ReplicationConfig.pm | 14 +++++
3 files changed, 177 insertions(+), 23 deletions(-)
--
2.30.2
next reply other threads:[~2021-08-12 11:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 11:00 Fabian Ebner [this message]
2021-08-12 11:01 ` [pve-devel] [PATCH v3 storage 1/3] zfspool: add zfs_get_sorted_snapshot_list helper Fabian Ebner
2021-08-12 11:01 ` [pve-devel] [PATCH v3 storage 2/3] zfspool: add blockers parameter to volume_snapshot_is_possible Fabian Ebner
2021-08-13 6:54 ` Fabian Ebner
2021-08-12 11:01 ` [pve-devel] [PATCH v3 storage 3/3] test: zfspool: extend some rollback is possible tests with new blockers parameter Fabian Ebner
2021-08-12 11:01 ` [pve-devel] [PATCH v3 container 1/1] config: rollback is possible: add " Fabian Ebner
2021-08-12 11:01 ` [pve-devel] [PATCH v3 qemu-server " Fabian Ebner
2021-08-12 11:01 ` [pve-devel] [PATCH v3 guest-common 1/7] partially fix #3111: snapshot rollback: improve removing replication snapshots Fabian Ebner
2021-08-12 11:01 ` [pve-devel] [PATCH v3 guest-common 2/7] config: rollback: factor out helper for " Fabian Ebner
2021-08-12 11:01 ` [pve-devel] [PATCH v3 guest-common 3/7] partially fix #3111: further improve " Fabian Ebner
2021-08-12 11:01 ` [pve-devel] [PATCH v3 guest-common 4/7] replication: remove unused variable and style fixes Fabian Ebner
2021-08-12 11:01 ` [pve-devel] [PATCH v3 guest-common 5/7] replication: pass guest config to find_common_replication_snapshot Fabian Ebner
2021-08-12 11:01 ` [pve-devel] [PATCH v3 guest-common 6/7] partially fix #3111: replication: be less picky when selecting incremental base Fabian Ebner
2021-08-12 11:01 ` [pve-devel] [RFC v3 guest-common 7/7] fix #3111: config: snapshot delete: check if replication still needs it Fabian Ebner
2021-10-06 6:59 ` [pve-devel] [PATCH-SERIES v3] fix #3111: fix interaction of snapshot operations with replication Fabian Ebner
2021-11-09 16:49 ` [pve-devel] applied-series: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812110111.73883-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox