From: Fabian Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [RFC common 1/1] REST environment: add static log_warn function
Date: Fri, 6 Aug 2021 14:57:11 +0200 [thread overview]
Message-ID: <20210806125712.96863-1-f.ebner@proxmox.com> (raw)
which can be called even when the environment is not initialized.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
src/PVE/RESTEnvironment.pm | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/PVE/RESTEnvironment.pm b/src/PVE/RESTEnvironment.pm
index 189a6cd..4278966 100644
--- a/src/PVE/RESTEnvironment.pm
+++ b/src/PVE/RESTEnvironment.pm
@@ -712,14 +712,20 @@ sub fork_worker {
return wantarray ? ($upid, $res) : $upid;
}
-sub warn {
- my ($self, $message) = @_;
+sub log_warn {
+ my ($message) = @_;
chomp($message);
print STDERR "WARN: $message\n";
- $self->{warning_count}++;
+ $rest_env->{warning_count}++ if $rest_env;
+}
+
+sub warn {
+ my ($self, $message) = @_;
+
+ log_warn($message);
}
# Abstract function
--
2.30.2
next reply other threads:[~2021-08-06 12:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 12:57 Fabian Ebner [this message]
2021-08-06 12:57 ` [pve-devel] [RFC container 1/1] print_ct_warn_log: use log_warn function from RESTEnvironment Fabian Ebner
2021-08-23 16:22 ` [pve-devel] [RFC common 1/1] REST environment: add static log_warn function Thomas Lamprecht
2021-09-01 11:02 ` Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210806125712.96863-1-f.ebner@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox