From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: [pve-devel] applied series: [PATCH container/manager v2] default nesting for unpriv containers in ui
Date: Wed, 4 Aug 2021 14:20:19 +0200 [thread overview]
Message-ID: <20210804122019.eibjtyosq5d7qhjg@wobu-vie.proxmox.com> (raw)
In-Reply-To: <20210804105111.183355-1-d.csapak@proxmox.com>
applied series
On Wed, Aug 04, 2021 at 12:51:06PM +0200, Dominik Csapak wrote:
> since many modern containers need the nesting feature to work properly
> (thanks systemd...), we add a checkbox that is on by default
> (and disables with unprivileged, since nested privileged containers
> are not very secure)
>
> to do that, we first have to loosen the nesting constraints in the api
> a bit. we do that by allowing to set that for unprivileged containers
> when the user has the 'VM.Allocate' privilege.
>
> (just to note: a user with that right can also create privileged
> containers, but could not enable nesting for them)
>
> changes from v1:
> * prevent comparing undefined $(old)features->{$features} by first
> extracting it into a variable with a fallback of '' and compare that
> * reorder the permission checks so that they are returned consistently
> * add patch that removes features when restoring an unprivileged
> container as privileged
>
> pve-container:
>
> Dominik Csapak (3):
> add old config and unprivileged to check_ct_modify_config_perm
> allow nesting to be changed for VM.Allocate on unprivileged containers
> skip features when restoring an unprivileged container as privileged
>
> src/PVE/API2/LXC.pm | 6 +--
> src/PVE/API2/LXC/Config.pm | 95 +++++++++++++++++++-------------------
> src/PVE/LXC.pm | 47 +++++++++++++++++--
> src/PVE/LXC/Create.pm | 5 ++
> 4 files changed, 100 insertions(+), 53 deletions(-)
>
> pve-manager:
>
> Dominik Csapak (2):
> ui: lxc/Options: allow opening features window for VM.Allocate
> ui: lxc/CreateWizard: add a 'nesting' checkbox and enable it by
> default
>
> www/manager6/lxc/CreateWizard.js | 10 ++++++++++
> www/manager6/lxc/Options.js | 2 +-
> 2 files changed, 11 insertions(+), 1 deletion(-)
>
> --
> 2.30.2
prev parent reply other threads:[~2021-08-04 12:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 10:51 [pve-devel] " Dominik Csapak
2021-08-04 10:51 ` [pve-devel] [PATCH container v2 1/3] add old config and unprivileged to check_ct_modify_config_perm Dominik Csapak
2021-08-04 10:51 ` [pve-devel] [PATCH container v2 2/3] allow nesting to be changed for VM.Allocate on unprivileged containers Dominik Csapak
2021-08-04 10:51 ` [pve-devel] [PATCH container v2 3/3] skip features when restoring an unprivileged container as privileged Dominik Csapak
2021-08-04 10:51 ` [pve-devel] [PATCH manager v2 1/2] ui: lxc/Options: allow opening features window for VM.Allocate Dominik Csapak
2021-08-04 10:51 ` [pve-devel] [PATCH manager v2 2/2] ui: lxc/CreateWizard: add a 'nesting' checkbox and enable it by default Dominik Csapak
2021-08-04 12:20 ` Wolfgang Bumiller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210804122019.eibjtyosq5d7qhjg@wobu-vie.proxmox.com \
--to=w.bumiller@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox