From: Lorenz Stechauner <l.stechauner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH v3 storage 2/3] status: remove sleep(1) in file upload
Date: Tue, 3 Aug 2021 14:16:34 +0200 [thread overview]
Message-ID: <20210803121640.2530993-4-l.stechauner@proxmox.com> (raw)
In-Reply-To: <20210803121640.2530993-1-l.stechauner@proxmox.com>
this racey sleep(1) is only there for legacy reasons: because
we don't use apache anymore and only emulate its behabiour
regarding removing temp files, this is under our own control
now and so we can improve this whole situation.
this change requires a pve-http-server version, in which the
tmpfile gets not automatically removed anymore.
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
---
PVE/API2/Storage/Status.pm | 9 +--------
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/PVE/API2/Storage/Status.pm b/PVE/API2/Storage/Status.pm
index a5ac372..db5a76e 100644
--- a/PVE/API2/Storage/Status.pm
+++ b/PVE/API2/Storage/Status.pm
@@ -495,14 +495,7 @@ __PACKAGE__->register_method ({
print "finished file import successfully\n";
};
- my $upid = $rpcenv->fork_worker('imgcopy', undef, $user, $worker);
-
- # apache removes the temporary file on return, so we need
- # to wait here to make sure the worker process starts and
- # opens the file before it gets removed.
- sleep(1);
-
- return $upid;
+ return $rpcenv->fork_worker('imgcopy', undef, $user, $worker);
}});
__PACKAGE__->register_method({
--
2.30.2
next prev parent reply other threads:[~2021-08-03 12:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 12:16 [pve-devel] [PATCH-SERIES v3 http-server/storage/manager] fix #3505: add checksum and algorithm to iso upload Lorenz Stechauner
2021-08-03 12:16 ` [pve-devel] [PATCH v3 http-server 1/1] anyevent: move unlink from http-server to endpoint Lorenz Stechauner
2021-08-03 12:16 ` [pve-devel] [PATCH v3 storage 1/3] status: move unlink from http-server to enpoint Lorenz Stechauner
2021-08-23 16:14 ` Thomas Lamprecht
2021-08-26 16:30 ` Thomas Lamprecht
2021-08-30 11:54 ` Lorenz Stechauner
2021-08-31 7:51 ` Thomas Lamprecht
2021-08-03 12:16 ` Lorenz Stechauner [this message]
2021-08-03 12:16 ` [pve-devel] [PATCH v3 storage 3/3] fix #3505: status: add checksum and algorithm to file upload Lorenz Stechauner
2021-08-03 12:16 ` [pve-devel] [PATCH v3 manager 1/5] ui: move upload window into UploadToStorage.js Lorenz Stechauner
2021-08-03 12:16 ` [pve-devel] [PATCH v3 manager 2/5] ui: refactor UploadToStorage.js Lorenz Stechauner
2021-08-03 12:16 ` [pve-devel] [PATCH v3 manager 3/5] fix #3505: ui/UploadToStorage: add checksum and algorithm Lorenz Stechauner
2021-08-03 12:16 ` [pve-devel] [PATCH v3 manager 4/5] ui/UploadToStorage: add TaskViewer Lorenz Stechauner
2021-08-03 12:16 ` [pve-devel] [PATCH v3 manager 5/5] ui/UplaodToStorage: check file extension Lorenz Stechauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210803121640.2530993-4-l.stechauner@proxmox.com \
--to=l.stechauner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox