From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] [PATCH widget-toolkit] node/Tasks: show correct node-specific task log
Date: Fri, 23 Jul 2021 08:59:35 +0200 [thread overview]
Message-ID: <20210723065935.625817-1-d.csapak@proxmox.com> (raw)
while refactoring, we forgot to replace the 'localhost' url
(which is valid for pmg/pbs) with the actual nodename we have in pve
do this by setting the correct url in the viewModel right at the start
of the initComponent
we now also have the possiblitiy to overwrite the url if we want
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
src/node/Tasks.js | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/node/Tasks.js b/src/node/Tasks.js
index c852615..3d7113d 100644
--- a/src/node/Tasks.js
+++ b/src/node/Tasks.js
@@ -199,7 +199,7 @@ Ext.define('Proxmox.node.Tasks', {
startParam: 'start',
limitParam: 'limit',
extraParams: '{extraParams}',
- url: "/api2/json/nodes/localhost/tasks",
+ url: '{url}',
},
listeners: {
prefetch: 'updateLayout',
@@ -443,6 +443,10 @@ Ext.define('Proxmox.node.Tasks', {
initComponent: function() {
const me = this;
+ let nodename = me.nodename || 'localhost';
+ let url = me.url || `/api2/json/nodes/${nodename}/tasks`;
+ me.getViewModel().set('url', url);
+
let updateExtraFilters = function(name, value) {
let vm = me.getViewModel();
let extraFilter = Ext.clone(vm.get('extraFilter'));
--
2.30.2
next reply other threads:[~2021-07-23 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-23 6:59 Dominik Csapak [this message]
2021-07-23 7:01 ` Dominik Csapak
2021-07-27 14:35 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210723065935.625817-1-d.csapak@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox