public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH qemu-server] Fix #3371: parse ovf: Allow dots in VM name
@ 2021-07-21 10:06 Dominic Jäger
  2021-07-29 15:18 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Dominic Jäger @ 2021-07-21 10:06 UTC (permalink / raw)
  To: pve-devel

Dots are allow in PVE VM names, so they should not be dropped during import.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
---
 PVE/QemuServer/OVF.pm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/PVE/QemuServer/OVF.pm b/PVE/QemuServer/OVF.pm
index c76c199..0376cbf 100644
--- a/PVE/QemuServer/OVF.pm
+++ b/PVE/QemuServer/OVF.pm
@@ -111,7 +111,8 @@ sub parse_ovf {
     my $ovf_name = $xpc->findvalue($xpath_find_name);
 
     if ($ovf_name) {
-	($qm->{name} = $ovf_name) =~ s/[^a-zA-Z0-9\-]//g; # PVE::QemuServer::confdesc requires a valid DNS name
+	# PVE::QemuServer::confdesc requires a valid DNS name
+	($qm->{name} = $ovf_name) =~ s/[^a-zA-Z0-9\-\.]//g;
     } else {
 	warn "warning: unable to parse the VM name in this OVF manifest, generating a default value\n";
     }
-- 
2.30.2





^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: Re: [PATCH qemu-server] Fix #3371: parse ovf: Allow dots in VM name
  2021-07-21 10:06 [pve-devel] [PATCH qemu-server] Fix #3371: parse ovf: Allow dots in VM name Dominic Jäger
@ 2021-07-29 15:18 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-07-29 15:18 UTC (permalink / raw)
  To: Proxmox VE development discussion, Dominic Jäger

On 21/07/2021 12:06, Dominic Jäger wrote:
> Dots are allow in PVE VM names, so they should not be dropped during import.
> 
> Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
> ---
>  PVE/QemuServer/OVF.pm | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-07-29 15:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-21 10:06 [pve-devel] [PATCH qemu-server] Fix #3371: parse ovf: Allow dots in VM name Dominic Jäger
2021-07-29 15:18 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal