public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Wolfgang Bumiller <w.bumiller@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Oguz Bektas <o.bektas@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH container v3] fix #3516: fix unmanaged containers
Date: Tue, 20 Jul 2021 14:08:48 +0200	[thread overview]
Message-ID: <20210720120848.jt6utnuojtn2ygya@wobu-vie.proxmox.com> (raw)
In-Reply-To: <95dc2d98-ec11-e8c9-1761-9fe91d18af1a@proxmox.com>

On Tue, Jul 20, 2021 at 01:59:45PM +0200, Thomas Lamprecht wrote:
> or we can avoid further hacks, separate the plugin ABI in an actual "interface only"
> module which base and a new unmanaged plugin depends on, so that we can actually drop
> that special case and with it all the `return if  !$self->{plugin}; # unmanaged` stanzas
> completely...

sounds good to me 👍




  reply	other threads:[~2021-07-20 12:09 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14  9:51 Oguz Bektas
2021-07-20 11:29 ` Oguz Bektas
2021-07-20 11:44   ` Thomas Lamprecht
2021-07-20 11:40 ` Wolfgang Bumiller
2021-07-20 11:49   ` Thomas Lamprecht
2021-07-20 11:51     ` Oguz Bektas
2021-07-20 11:59       ` Thomas Lamprecht
2021-07-20 12:08         ` Wolfgang Bumiller [this message]
2021-07-20 11:50   ` Wolfgang Bumiller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210720120848.jt6utnuojtn2ygya@wobu-vie.proxmox.com \
    --to=w.bumiller@proxmox.com \
    --cc=o.bektas@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal